- Notifications
You must be signed in to change notification settings - Fork5.7k
Unify datetime import in all files#4605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* update datetime to datetime as dtm in test folder* update datetime to datetime as dtm in test/auxil, test/ext folders* fix black format errors
…cia entre módulos (#1)* Refactor datetime imports to use alias for consistency* Refactor datetime imports to use alias for consistency across modules* Refactor datetime imports to use alias for consistency in ChatMemberUpdated, Giveaway, Message, MessageOrigin modules* Refactor datetime imports to use alias for consistency in ChatJoinRequest and ChatMember modules* Full Support for Bot API 8.0 (python-telegram-bot#4566,python-telegram-bot#4568,python-telegram-bot#4570,python-telegram-bot#4571,python-telegram-bot#4574,python-telegram-bot#4576,python-telegram-bot#4572)* Documentation Improvements (python-telegram-bot#4573,python-telegram-bot#4565)Co-authored-by: Snehashish Biswas <coderrx06@gmail.com>Co-authored-by: poolitzer <github@poolitzer.eu>* Bump Version to v21.8 (python-telegram-bot#4583)* Bump `srvaroa/labeler` from 1.11.1 to 1.12.0 (python-telegram-bot#4586)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* Bump `pylint` to v3.3.2 to Improve Python 3.13 Support (python-telegram-bot#4590)* Bump `codecov/codecov-action` from 4 to 5 (python-telegram-bot#4585)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>* Allow `Sequence` Input for `allowed_updates` in `Application` and `Updater` Methods (python-telegram-bot#4589)* Full Support for Bot API 8.1 (python-telegram-bot#4594)* Use `MessageLimit.DEEP_LINK_LENGTH` in `helpers.create_deep_linked_url` (python-telegram-bot#4597)* Bump `pytest` from 8.3.3 to 8.3.4 (python-telegram-bot#4596)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>* Update `aiolimiter` requirement from ~=1.1.0 to >=1.1,<1.3 (python-telegram-bot#4595)Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>* Bump Version to v21.9 (python-telegram-bot#4601)* Reorder imports to unify `datetime` usage across modules---------Signed-off-by: dependabot[bot] <support@github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>Co-authored-by: Snehashish Biswas <coderrx06@gmail.com>Co-authored-by: poolitzer <github@poolitzer.eu>Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Co-authored-by: Luis Pérez <luis.i.perez.0@gmail.com>Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>Co-authored-by: Juan Andrés Cuevas <juanandrescuevas14@gmail.com>
…tion_error_date to use dtm.datetime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks pretty good at first glance! Thanks for the fix!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you very much for the PR!
I just found two additionalimport datetime s intest_jobqueue andtest_businessmessagesdeletedhandler, otherwise LGTM :)
…sinessmessagesdeletedhandler.py and test_jobqueue.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the update! Now unfortunately something went wrong with merging master: Apparently you reverted the merge indda1e7c - please revert the revert 😅
This reverts commitdda1e7c.
4f255b6 intopython-telegram-bot:masterUh oh!
There was an error while loading.Please reload this page.
Thank you very much for the contribution :) |
Unifiy datetime import in all files
@Jeam-zx
@Migueldsc12
@AnyaMarcanito
@henryg311
@cuevasrja
Summary
Convert all datetime imports of the project to
import datetime as dtm. Since there was no standard in importing functions from this library.Tests
It was verified that all changes passed the static check performed by the linters and other project tools with the
pre-commit run -acommand.Check-list
This checklist is a non-exhaustive reminder of things that should be done before a PR is merged, both for you as contributor and for the maintainers. Feel free to copy (parts of) the checklist to the PR description to remind you or the maintainers of open points or if you have questions on anything.
Issue
Resolves#4577