Update pylint pre-commit hook to support py3.13 venvs#4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Bibo-Joshi merged 1 commit intopython-telegram-bot:masterfromnemacysts:pre-commit-update-for-python3.13

Dec 4, 2024

Merged

Update pylint pre-commit hook to support py3.13 venvs#4590

Bibo-Joshi merged 1 commit intopython-telegram-bot:masterfromnemacysts:pre-commit-update-for-python3.13

Dec 4, 2024

Conversation

Copy link

Contributor

nemacysts commentedDec 4, 2024

Without this change, runningpre-commit inside a Python 3.13 venv results in errors as described inpylint-dev/pylint#10000

e.g.:

************* Module telegram._bottelegram/_bot.py:26:0: E0611: No name 'Sequence' in module 'collections.abc' (no-name-in-module)

Bumping this hook required ignoring a new check added in pylint 3.3.0:too-many-positional-arguments as there's a significant amount of violations and picking a value for--max-positional-arguments seems non-trivial as there are functions with 80+ args (e.g.,Message::__init__() intelegram/_message.py)

run pre-commit
run tests
add self to AUTHORS.rst

Update pylint pre-commit hook to support py3.13 venvs

466a01b

Without this change, running `pre-commit` inside a Python 3.13 venvresults in errors as described inpylint-dev/pylint#10000e.g.:```************* Module telegram._bottelegram/_bot.py:26:0: E0611: No name 'Sequence' in module 'collections.abc' (no-name-in-module)```Bumping this hook required ignoring a new check added in pylint 3.3.0:`too-many-positional-arguments` as there's a significant amount ofviolations and picking a value for `--max-positional-arguments` seemsnon-trivial as there are functions with 80+ args (e.g.,`Message::__init__()` in `telegram/_message.py`)