Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Bot API 8.0: Gifts#4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 8 commits intoapi-8.0fromapi-8.0-gifts-transationpartneruser
Nov 28, 2024
Merged

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-JoshiBibo-Joshi commentedNov 24, 2024•
edited
Loading

Note thatTransactionPartnerUser was implemented to be atimedelta object in the spirit of#4575

  • Shortcuts
    • Chat.send_gift
    • [ ]CallbackQuery.reply_gift?
    • User.send_gift
  • Defaults integration oftext_parse_mode
  • extendconstants

@Bibo-JoshiBibo-Joshi added the ⚙️ bot-apiaffected functionality: bot-api labelNov 24, 2024
@Bibo-JoshiBibo-Joshi mentioned this pull requestNov 24, 2024
42 tasks
@codecovCodecov
Copy link

codecovbot commentedNov 24, 2024•
edited
Loading

❌ 2 Tests Failed:

Tests completedFailedPassedSkipped
606126059254
View the top 2 failed tests by shortest run time
tests.test_bot.TestBotWithoutRequest::test_camel_case_aliases[Bot.get_available_gifts]
Stack Traces | 0.002s run time
self=<tests.test_bot.TestBotWithoutRequestobjectat0x0000020F6FA493B0>bot_class=<class'telegram._bot.Bot'>,bot_method_name='get_available_gifts'bot_method=<functionBot.get_available_giftsat0x0000020F6D0F4360>    @bot_methods()deftest_camel_case_aliases(self,bot_class,bot_method_name,bot_method):camel_case_name=to_camel_case(bot_method_name)camel_case_function=getattr(bot_class,camel_case_name,False)>assertcamel_case_functionisnotFalse,f"{camel_case_name} not found"EAssertionError:getAvailableGiftsnotfoundEassertFalseisnotFalsetests\test_bot.py:438:AssertionError
tests.test_bot.TestBotWithoutRequest::test_camel_case_aliases[ExtBot.get_available_gifts]
Stack Traces | 0.002s run time
self=<tests.test_bot.TestBotWithoutRequestobjectat0x0000020F6FA800A0>bot_class=<class'telegram.ext._extbot.ExtBot'>bot_method_name='get_available_gifts'bot_method=<functionExtBot.get_available_giftsat0x0000020F6E271580>    @bot_methods()deftest_camel_case_aliases(self,bot_class,bot_method_name,bot_method):camel_case_name=to_camel_case(bot_method_name)camel_case_function=getattr(bot_class,camel_case_name,False)>assertcamel_case_functionisnotFalse,f"{camel_case_name} not found"EAssertionError:getAvailableGiftsnotfoundEassertFalseisnotFalsetests\test_bot.py:438:AssertionError

To view more test analytics, go to theTest Analytics Dashboard
Got feedback? Let us know onGithub

@Bibo-JoshiBibo-Joshi marked this pull request as ready for reviewNovember 27, 2024 05:51
@Bibo-JoshiBibo-Joshi merged commite785649 intoapi-8.0Nov 28, 2024
21 of 22 checks passed
@Bibo-JoshiBibo-Joshi deleted the api-8.0-gifts-transationpartneruser branchNovember 28, 2024 18:43
@Bibo-JoshiBibo-Joshi mentioned this pull requestNov 28, 2024
30 tasks
Copy link
Member

@PoolitzerPoolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Bit weird we have to do a class for a list of objects :D

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 8, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@PoolitzerPoolitzerPoolitzer left review comments

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Bibo-Joshi@Poolitzer
[8]ページ先頭
©2009-2025 Movatter.jp