- Notifications
You must be signed in to change notification settings - Fork5.7k
Improve Type Completeness#4466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
19 commits Select commitHold shift + click to select a range
d927cc4
Improve Type Completeness
Bibo-Joshi51f2fd2
Fix mypy for example
Bibo-Joshi7500927
Update telegram/ext/_callbackcontext.py
Bibo-Joshi2d4f439
Add monthly run + demo
Bibo-Joshieeaea7c
Merge branch 'refs/heads/master' into bump-type-completeness
Bibo-Joshidb59e9f
Try fixing workflow
Bibo-Joshibfb9287
Rework non-working demo
Bibo-Joshi820a3ed
Revert previous commits for demo
Bibo-Joshieb1f3ce
try fixing workflow
Bibo-Joshi7d77951
again
Bibo-Joshi69e7735
again
Bibo-Joshidfdc68c
again
Bibo-Joshifee9db7
Try fixing
Bibo-Joshi535814e
Aha, we're getting closer
Bibo-Joshidf486e0
Small improvement
Bibo-Joshi3361871
Revert "Revert previous commits for demo"
Bibo-Joshi48cc867
Merge branch 'refs/heads/master' into bump-type-completeness
Bibo-Joshie01708a
Merge branch 'refs/heads/master' into bump-type-completeness
Bibo-Joshidbdec8f
Remove demo pr trigger
Bibo-JoshiFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions.github/workflows/type_completeness_monthly.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
name: Check Type Completeness Monthly Run | ||
on: | ||
schedule: | ||
# Run first friday of the month at 03:17 - odd time to spread load on GitHub Actions | ||
- cron: '17 3 1-7 * 5' | ||
jobs: | ||
test-type-completeness: | ||
name: test-type-completeness | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: Bibo-Joshi/pyright-type-completeness@1.0.0 | ||
id: pyright-type-completeness | ||
with: | ||
package-name: telegram | ||
python-version: 3.12 | ||
pyright-version: ~=1.1.367 | ||
- name: Check Output | ||
uses: jannekem/run-python-script-action@v1 | ||
env: | ||
TYPE_COMPLETENESS: ${{ steps.pyright-type-completeness.outputs.base-completeness-score }} | ||
with: | ||
script: | | ||
import os | ||
completeness = float(os.getenv("TYPE_COMPLETENESS")) | ||
if completeness >= 1: | ||
exit(0) | ||
text = f"Type Completeness Decreased to {completeness}. ❌" | ||
error(text) | ||
set_summary(text) | ||
exit(1) |
4 changes: 2 additions & 2 deletionsexamples/nestedconversationbot.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
12 changes: 7 additions & 5 deletionstelegram/ext/_application.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 10 additions & 6 deletionstelegram/ext/_callbackcontext.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7 changes: 4 additions & 3 deletionstelegram/ext/_handlers/basehandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionstelegram/ext/_handlers/businessconnectionhandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionstelegram/ext/_handlers/businessmessagesdeletedhandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionstelegram/ext/_handlers/callbackqueryhandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletionstelegram/ext/_handlers/chatboosthandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionstelegram/ext/_handlers/chatjoinrequesthandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionstelegram/ext/_handlers/chatmemberhandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionstelegram/ext/_handlers/choseninlineresulthandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletionstelegram/ext/_handlers/commandhandler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.