Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve Type Completeness#4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 19 commits intomasterfrombump-type-completeness
Sep 14, 2024
Merged

Improve Type Completeness#4466

Bibo-Joshi merged 19 commits intomasterfrombump-type-completeness
Sep 14, 2024

Conversation

Bibo-Joshi
Copy link
Member

Based on#4460 (comment)

The typing ofCallbackContext got a tad less precise due to theJob[Any]. It appears thatpyright wants us to usetyping.Self (tried, it works with that), but that's available only in py3.11.

@Bibo-JoshiBibo-Joshi added the ⚙️ type-hintingaffected functionality: type-hinting labelSep 8, 2024
the proper solution would be to make CH accept Sequences (covariant), but I ain't touching CH for this …
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

interesting that the score dropped like 2 months ago but we didn't notice it. Did the test fail and we merged it anyway?

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi
Copy link
MemberAuthor

No, the problem is that the type completeness check has no memory across commits. So for each PR it needs to re-compute the type completeness of the head. so you have

  1. commit A, merged after testing with pyright 1.1.372, type score 1.0
  2. PR, comparing against commit A, recomputes with pyright 1.1.373, type score 0.976

If we wanted to catch these hases, we'd have to have something like codecov, i.e. a database for the type score per commit.
the upside of the current behavior is that a pyright update doesn't mark your PR as invalid even though your PR doesn't in itself decrease the type completeness …

@harshil21
Copy link
Member

@Bibo-Joshi I see. Can we not run a sanity check every month or so to see if the score dropped below 1.0?

@Bibo-Joshi
Copy link
MemberAuthor

Don't know if I'm too tired or if the output is not set correctly by the reusable action. Will have to retry someday

@Bibo-Joshi
Copy link
MemberAuthor

⇒ ready from my side :)

@Bibo-JoshiBibo-Joshi merged commit6b5e46c intomasterSep 14, 2024
26 of 27 checks passed
@Bibo-JoshiBibo-Joshi deleted the bump-type-completeness branchSeptember 14, 2024 06:16
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 22, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
⚙️ type-hintingaffected functionality: type-hinting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Bibo-Joshi@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp