- Notifications
You must be signed in to change notification settings - Fork5.7k
Improve Type Completeness#4466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
the proper solution would be to make CH accept Sequences (covariant), but I ain't touching CH for this …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
interesting that the score dropped like 2 months ago but we didn't notice it. Did the test fail and we merged it anyway?
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
No, the problem is that the type completeness check has no memory across commits. So for each PR it needs to re-compute the type completeness of the head. so you have
If we wanted to catch these hases, we'd have to have something like codecov, i.e. a database for the type score per commit. |
@Bibo-Joshi I see. Can we not run a sanity check every month or so to see if the score dropped below 1.0? |
Don't know if I'm too tired or if the output is not set correctly by the reusable action. Will have to retry someday |
This reverts commit820a3ed.
⇒ ready from my side :) |
6b5e46c
intomasterUh oh!
There was an error while loading.Please reload this page.
Based on#4460 (comment)
The typing of
CallbackContext
got a tad less precise due to theJob[Any]
. It appears thatpyright
wants us to usetyping.Self
(tried, it works with that), but that's available only in py3.11.