- Notifications
You must be signed in to change notification settings - Fork5.7k
Enforce theoffline_bot
fixture inTest*WithoutRequest
#4465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
By cutting of the internet connection in the fixtures
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
ec909e6
intomasterUh oh!
There was an error while loading.Please reload this page.
Follow-up for#4454. based on that branch, merge after.
Uses the
offline_bot
in all the*WithoutRequest
tests and fixes the very few places where requests where still being made.The check for enforcing
offline_bot
is now configured to run only on GitHub and only in one of the several test matrix runs. IMO this should suffice and avoids running additional if-checks on every single test function unnecessarily.