Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enforce theoffline_bot fixture inTest*WithoutRequest#4465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 11 commits intomasterfromno-request-tests-non-ext
Sep 13, 2024

Conversation

Bibo-Joshi
Copy link
Member

Follow-up for#4454. based on that branch, merge after.
Uses theoffline_bot in all the*WithoutRequest tests and fixes the very few places where requests where still being made.
The check for enforcingoffline_bot is now configured to run only on GitHub and only in one of the several test matrix runs. IMO this should suffice and avoids running additional if-checks on every single test function unnecessarily.

@Bibo-JoshiBibo-Joshi added the ⚙️ testsaffected functionality: tests labelSep 8, 2024
Base automatically changed fromno-request-tests tomasterSeptember 9, 2024 05:32
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@Bibo-JoshiBibo-Joshi merged commitec909e6 intomasterSep 13, 2024
24 of 25 checks passed
@Bibo-JoshiBibo-Joshi deleted the no-request-tests-non-ext branchSeptember 13, 2024 17:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 21, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
⚙️ testsaffected functionality: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Bibo-Joshi@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp