Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

API 7.10 -PaidMediaPurchased#4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
harshil21 merged 4 commits intoapi-7.10fromapi-7.10-update-arg
Sep 11, 2024
Merged

Conversation

harshil21
Copy link
Member

Part of#4459

Checklist for PRs

  • Added.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSION or.. versionremoved:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s
  • Checked theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_

  • Created a PR to remove functionality deprecated in the previous Bot API release (see here <https://docs.python-telegram-bot.org/en/stable/stability_policy.html#case-2>_)

  • New classes:

    • Addedself._id_attrs and corresponding documentation
    • __init__ acceptsapi_kwargs as kw-only
  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that acceptchat/user_id
    • In :class:~telegram.Message for all methods that acceptchat_id andmessage_id
    • For new :class:~telegram.Message shortcuts: Addedquote argument if methods acceptsreply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables

    • Link new and existing constants in docstrings instead of hard-coded numbers and strings

    • Add new message types to :attr:telegram.Message.effective_attachment

    • Added new handlers for new update types

      • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
    • Added new filters for new message (sub)types

    • Added or updated documentation for the changed class(es) and/or method(s)

    • Added the new method(s) to_extbot.py

    • Added or updatedbot_methods.rst

    • Updated the Bot API version number in all places:README.rst (including the badge) andtelegram.constants.BOT_API_VERSION_INFO

    • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept areply_markup in some form or have a return type that is/contains :class:~telegram.Message

@harshil21harshil21 added the ⚙️ bot-apiaffected functionality: bot-api labelSep 8, 2024
@harshil21harshil21 changed the base branch frommaster toapi-7.10September 8, 2024 04:23
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice PR! Just a few nitpicks :)

@Bibo-JoshiBibo-Joshi mentioned this pull requestSep 8, 2024
@harshil21
Copy link
MemberAuthor

harshil21 commentedSep 8, 2024
edited
Loading

Should I adjust the type completness passing threshold value? It seems all the handler files have some type problems so that's why the check failed

nvm: I think we used to have a threshold, now it doesn't seem to exist

@Bibo-Joshi
Copy link
Member

Without having looked too closely, my guess is that there is only one typing problem. the rest propagates through the other classes b/c of the "Generic" dependencies they have on each other

@Bibo-Joshi
Copy link
Member

@Bibo-JoshiBibo-Joshi mentioned this pull requestSep 8, 2024
@Bibo-Joshi
Copy link
Member

lgtm, then, merge at will :)

@harshil21harshil21 merged commit37783fa intoapi-7.10Sep 11, 2024
21 of 25 checks passed
@harshil21harshil21 deleted the api-7.10-update-arg branchSeptember 11, 2024 20:38
Bibo-Joshi added a commit that referenced this pull requestSep 17, 2024
Co-authored-by: aelkheir <90580077+aelkheir@users.noreply.github.com>Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi requested changes

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@harshil21@Bibo-Joshi

[8]ページ先頭

©2009-2025 Movatter.jp