Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make Tests fortelegram.ext Independent of Networking#4454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 7 commits intomasterfromno-request-tests
Sep 9, 2024

Conversation

Bibo-Joshi
Copy link
Member

By cutting of the internet connection in the fixtures

  • provide a new fixtureoffline_bot that has no internet connection
  • override fixtures for the tests inext to have no internet connection
  • manually adapt a few tests
  • also move other ext-only-fixtures from conftest to ext\conftest on the fly

Let's see if I got everything in local testing

supersedes#4317. Although this PR here doesn't cover cutting off the internet connection in the*WithoutRequest tests, I don't think I'll follow up on that for the reasons pointed out in#4317.

By cutting of the internet connection in the fixtures
@Bibo-JoshiBibo-Joshi added the ⚙️ testsaffected functionality: tests labelSep 3, 2024
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Alright, looks good to me. Regarding theWithoutRequest tests, after we useoffline_bot there as well, I'm wondering if we can disallow thebot fixture to be used in those tests. As you mentioned, it's close to impossible to effectively enforce this, but it's a decent try.

We can get the fixture list usingfixturenames it seems.

@Bibo-Joshi
Copy link
MemberAuthor

Alright, looks good to me. Regarding the WithoutRequest tests, after we use offline_bot there as well, I'm wondering if we can disallow the bot fixture to be used in those tests. As you mentioned, it's close to impossible to effectively enforce this, but it's a decent try.

I would like to move this to a different PR …

harshil21 reacted with thumbs up emoji

@Bibo-Joshi
Copy link
MemberAuthor

All right. Looks like I've got all tests working by now and also managed to reduce repetitions a bit. So now actually ready for review 😅

@Bibo-JoshiBibo-Joshi merged commit0b352b0 intomasterSep 9, 2024
24 of 25 checks passed
@Bibo-JoshiBibo-Joshi deleted the no-request-tests branchSeptember 9, 2024 05:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 17, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
⚙️ testsaffected functionality: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Bibo-Joshi@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp