Rename Testing Base Classes#4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Bibo-Joshi merged 1 commit intomasterfromrename-test-classes

Sep 3, 2024

Merged

Rename Testing Base Classes#4453

Bibo-Joshi merged 1 commit intomasterfromrename-test-classes

Sep 3, 2024

Conversation

Copy link

Member

Bibo-Joshi commentedSep 3, 2024

addresses part sof#4324

Example console output before and after renaming:

(venv311)~\PycharmProjects\python-telegram-bot git:[rename-test-classes]pytest -v -k NoMatchTest=======================================================================test session starts =======================================================================platform win32 -- Python 3.11.9, pytest-8.2.2, pluggy-1.5.0 -- C:\Users\hinri\PycharmProjects\python-telegram-bot\venv311\Scripts\python.execachedir: .pytest_cacherootdir: C:\Users\hinri\PycharmProjects\python-telegram-botconfigfile: pyproject.tomltestpaths: testsplugins: anyio-4.4.0, flaky-3.8.1, asyncio-0.21.2, socket-0.7.0, xdist-3.6.1, web3-6.18.0asyncio: mode=Mode.AUTOcollected 6200 items / 6200 deselected / 0 selected                                                                                                                ==================================================================== 6200 deselectedin 17.72s ====================================================================(venv311)~\PycharmProjects\python-telegram-bot git:[rename-test-classes]pytest -v -k NoMatchTest=======================================================================test session starts =======================================================================platform win32 -- Python 3.11.9, pytest-8.2.2, pluggy-1.5.0 -- C:\Users\hinri\PycharmProjects\python-telegram-bot\venv311\Scripts\python.execachedir: .pytest_cacherootdir: C:\Users\hinri\PycharmProjects\python-telegram-botconfigfile: pyproject.tomltestpaths: testsplugins: anyio-4.4.0, flaky-3.8.1, asyncio-0.21.2, socket-0.7.0, xdist-3.6.1, web3-6.18.0asyncio: mode=Mode.AUTOcollected 6200 items / 6200 deselected / 0 selected                                                                                                                ==================================================================== 6200 deselectedin 12.71s ====================================================================

Note that the number of collected items didnot change. What did change is the elapsed time, however I'm not sure if this is really reproducable. In any case, it doesn't hurt to rename these classes and if on average it does speed up the collection that's a good thing :)

Rename Testing Base Classes

2dacedf

Bibo-Joshi requested a review fromharshil21

September 3, 2024 02:30

Bibo-Joshi mentioned this pull request

Sep 3, 2024

Test suite maintainence and new ideas#4324

Open

14 tasks

Copy link

Member

harshil21 commentedSep 3, 2024•
edited
Loading

Thanks! I ranhyperfine withpytest's--collect-only, and the results were not conclusive (compared with master):

(python-telegram-bot) ➜  python-telegram-bot git:(master) ✗ hyperfine"pytest --collect-only"Benchmark 1: pytest --collect-only  Time (mean ± σ):      2.997 s ±  0.118 s    [User: 2.897 s, System: 0.094 s]  Range (min … max):    2.928 s …  3.310 s    10 runs   Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It mighthelp to use the'--warmup' or'--prepare' options. (python-telegram-bot) ➜  python-telegram-bot git:(master) ✗ git checkout rename-test-classes Switched to branch'rename-test-classes'Your branch is up to date with'origin/rename-test-classes'.(python-telegram-bot) ➜  python-telegram-bot git:(rename-test-classes) ✗ hyperfine"pytest --collect-only"Benchmark 1: pytest --collect-only  Time (mean ± σ):      3.207 s ±  0.933 s    [User: 3.107 s, System: 0.095 s]  Range (min … max):    2.888 s …  5.861 s    10 runs   Warning: The first benchmarking runfor thiscommand was significantly slower than the rest (5.861 s). This could be caused by (filesystem) caches that were not filleduntil after the first run. You should consider using the'--warmup' option to fill those caches before the actual benchmark. Alternatively, use the'--prepare' option to clear the caches before each timing run.