- Notifications
You must be signed in to change notification settings - Fork5.7k
Remove surplus logging from updater network loop#4432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfromMartinHjelmare:updater-logging-cleanupAug 19, 2024
Merged
Remove surplus logging from updater network loop#4432
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfromMartinHjelmare:updater-logging-cleanupAug 19, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
MartinHjelmare commentedAug 18, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Remaining CI test failures seem unrelated to the PR change. |
Bibo-Joshi approved these changesAug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice finding, thanks for seding a PR!
a05362c
intopython-telegram-bot:master 24 of 25 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Background
When there's a
TelegramError
in theUpdater._network_loop_retry
method, the exception is currently both logged and passed to theon_err_cb
.Example log:
Proposed changes