- Notifications
You must be signed in to change notification settings - Fork5.7k
Prepare for Py +3.9 support#4398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@elpekenin Python 3.8 reached EoL yesterday and 3.13 final was released. Do you want to still work on this or should we pick it up again? |
Will (try and) take a look later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Heyho. I've scrolled through the changes a bit, but didn't see anything besides the two comments below.@elpekenin what'sy our status on this PR otherwise? I see that it's still marked as draft.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@elpekenin@harshil21 if I don't hear vehement disagreement from you, I'll merge some time on the weekend :)
elpekenin commentedOct 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry for the silence, somehow i didnt get/see notifications about the feedback. I have no idea what
|
Its certainly weird 😅 my last commit seemed to work and I also checked that |
# Conflicts:#telegram/ext/_application.py
# Conflicts:#.github/workflows/unit_tests.yml
5ab82a9
intopython-telegram-bot:masterUh oh!
There was an error while loading.Please reload this page.
Thank you very much for the contribution :) |
As per title, so far:
List
->list
Type[UT]
typing.AsyncContextManager
3.8
to3.9
inpyproject.toml
str.removeprefix
(i might have missed a couple of places doing the same logic manually)