Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Prepare for Py +3.9 support#4398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 13 commits intopython-telegram-bot:masterfromelpekenin:39-changes
Oct 24, 2024

Conversation

elpekenin
Copy link
Contributor

As per title, so far:

  • Mass search+replace for stuff likeList->list
  • Silence warnings, while no better solution is found, forType[UT]
  • Update usages of deprecatedtyping.AsyncContextManager
  • Update3.8 to3.9 inpyproject.toml
  • Usestr.removeprefix (i might have missed a couple of places doing the same logic manually)

@harshil21
Copy link
Member

@elpekenin Python 3.8 reached EoL yesterday and 3.13 final was released. Do you want to still work on this or should we pick it up again?

@elpekenin
Copy link
ContributorAuthor

Will (try and) take a look later today

harshil21 reacted with thumbs up emoji

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Heyho. I've scrolled through the changes a bit, but didn't see anything besides the two comments below.@elpekenin what'sy our status on this PR otherwise? I see that it's still marked as draft.

@harshil21harshil21 added 🛠 breakingchange type: breaking 🔗 pythonrelated technology: python labelsOct 22, 2024
@Bibo-JoshiBibo-Joshi marked this pull request as ready for reviewOctober 23, 2024 20:07
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@elpekenin@harshil21 if I don't hear vehement disagreement from you, I'll merge some time on the weekend :)

@Bibo-JoshiBibo-Joshi changed the title[Draft] Prepare for Py +3.9 supportPrepare for Py +3.9 supportOct 23, 2024
@elpekenin
Copy link
ContributorAuthor

elpekenin commentedOct 23, 2024
edited
Loading

Sorry for the silence, somehow i didnt get/see notifications about the feedback.

I have no idea whatGenericUT[UT] is supposed to mean. From my understanding:

  • We wouldnt need an alias for the hint
  • Would just useType[UT] in there (uppercase just because tooling might get confused withtype also being the name of the variable)
  • ReferencingUT outside function would be the same as usingAny as it is not bound by the specific callers' typing (?)
    ... But its been such a headache trying stuff without any success that im fine with anything that tooling like :P

@Bibo-Joshi
Copy link
Member

But its been such a headache trying stuff without any success that im fine with anything that tooling like :P

Its certainly weird 😅 my last commit seemed to work and I also checked thatreveal_type produces sane output with both mypy and pyright, so it would be goos enough for me :D

# Conflicts:#telegram/ext/_application.py
# Conflicts:#.github/workflows/unit_tests.yml
@Bibo-JoshiBibo-Joshi merged commit5ab82a9 intopython-telegram-bot:masterOct 24, 2024
22 checks passed
@Bibo-Joshi
Copy link
Member

Thank you very much for the contribution :)

elpekenin reacted with hooray emoji

@elpekeninelpekenin deleted the 39-changes branchOctober 24, 2024 21:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
🛠 breakingchange type: breaking🔗 pythonrelated technology: python
Projects
Status: 3.9 - starting 10-2024
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@elpekenin@harshil21@Bibo-Joshi@Poolitzer

[8]ページ先頭

©2009-2025 Movatter.jp