Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[enhancement] move hardcoded encodings to contants#4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 2 commits intopython-telegram-bot:masterfromelpekenin:utf16
Jul 21, 2024

Conversation

elpekenin
Copy link
Contributor

As per title, just a very minor refactor

@elpekenin
Copy link
ContributorAuthor

Didn't change the hardcodedutf-8 indocs/source/conf.py, to prevent making it depend further on the project, can add the changes there too if desired

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! changing conf.py probably doesn't give a big benefit, also considerding that the import can't bee at the top … LGTM :)

@Bibo-JoshiBibo-Joshi merged commit0913b85 intopython-telegram-bot:masterJul 21, 2024
26 of 27 checks passed
@Bibo-Joshi
Copy link
Member

Thank you for the contribution!

elpekenin reacted with heart emoji

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 29, 2024
@elpekeninelpekenin deleted the utf16 branchSeptember 1, 2024 13:52
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@elpekenin@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp