- Notifications
You must be signed in to change notification settings - Fork5.7k
AddMessageEntity.shift_entities andMessageEntity.concatenate#4376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just a couple of nitpicks, LGTM
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
cool idea, I like it :)
Uh oh!
There was an error while loading.Please reload this page.
| by (Union[:obj:`str`, :obj:`int`]): Either the amount to shift the offset by or | ||
| a string whose length will be used as the amount to shift the offset by. In this | ||
| case, UTF-16 encoding will be used to calculate the length. | ||
| entities (Sequence[:class:`telegram.MessageEntity`]): Sequence of entities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| entities (Sequence[:class:`telegram.MessageEntity`]):Sequenceofentities | |
| entities (Sequence[:class:`telegram.MessageEntity`]):Sequenceofentitieswhose :paramref:`~telegram.MessageEntity.offset`willbeshifted :param:`by`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't that be clear by the description? : 🤔 it would at least have to be "by parameter by" ...
harshil21Aug 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
well yeah, but the description of the parameter just looked a bit too short. I'm fine with keeping as is then
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
e0f3686 intomasterUh oh!
There was an error while loading.Please reload this page.
closes#4372
The implemented signature for
ME.concatenatediffers from the one proposed in#4372 to allow concanetating several tuples of text & entities at once... versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor.. versionremoved:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__Added myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior