Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement game_pattern support in CQH#4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 28 commits intopython-telegram-bot:masterfromjainamoswal:jainamoswal-patch-1
Jul 13, 2024
Merged

Implement game_pattern support in CQH#4353

Bibo-Joshi merged 28 commits intopython-telegram-bot:masterfromjainamoswal:jainamoswal-patch-1
Jul 13, 2024

Conversation

jainamoswal
Copy link
Contributor

@jainamoswaljainamoswal commentedJul 7, 2024•
edited by Bibo-Joshi
Loading

Added thegame_pattern parameter to CQH to enablecallback_data-like support for filtering based ongame_short_name.

It supports

  • CQH(pattern=None, game_patterm=None) handles any CQ → backward compatible
  • CQH(pattern=pattern, game_patterm=None) handles only CQs with.data→ backward compatible
  • CQH(pattern=None, game_patterm=pattern) handles only CQs with.game_short_name. → still backward compatible sincegame_pattern defaults to None
  • CQH(pattern=pattern, game_patterm=game_pattern) handles only CQs with matching.data xor matching.game_short_name → also backward compatible since.data and.game_short_name are mutually exclusive

This PRcloses#4269.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, thanks for the PR! I left some comments below.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for the new updates. the logic now lgtm - except for one comment below. please let me know when you've implemented the tests so that I can give another review :)

@jainamoswal
Copy link
ContributorAuthor

I have added testshere.

As a newbie can't confirm if they are accurate or need some changes.

@jainamoswaljainamoswal marked this pull request as ready for reviewJuly 10, 2024 08:56
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM now :) thanks for the nice contribution and your cooperation in the review process!

@Bibo-JoshiBibo-Joshi merged commit422993b intopython-telegram-bot:masterJul 13, 2024
24 of 25 checks passed
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 21, 2024
@Bibo-JoshiBibo-Joshi added 🔌 enhancementpr description: enhancement and removed enhancement labelsNov 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

Assignees
No one assigned
Labels
🔌 enhancementpr description: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CallbackQueryHandler to support filtering game_short_name
2 participants
@jainamoswal@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp