Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Addadjust_message_entities_to_utf_16 utility#4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 6 commits intopython-telegram-bot:masterfromAntares0982:master
Jul 6, 2024

Conversation

Antares0982
Copy link
Contributor

addadjust_message_entities_to_utf_16 for#4319

@Antares0982
Copy link
ContributorAuthor

Antares0982 commentedJun 24, 2024•
edited
Loading

Is there anything else should be added/changed?

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, thank you very much for the PR! I left a number of comments. The overall logic is fine - thanks for catching the necessity for sorting! - but there are some things that can be improved :)

@Antares0982
Copy link
ContributorAuthor

Ok, I will fix these in the next few days

Bibo-Joshi reacted with rocket emoji

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the updates! Left some more comments, mostly about documentation :)
Please don't force-push additional changes, as that makes it hard to see what which parts I've already reviewed.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the additional updates! LGTM now :) If@harshil21 approves as well, we can merge.

Antares0982 reacted with rocket emoji
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one last doc fix

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-JoshiBibo-Joshi merged commit42d7c8c intopython-telegram-bot:masterJul 6, 2024
17 of 23 checks passed
@Bibo-Joshi
Copy link
Member

Thank you very much for the nice contribution!

Antares0982 reacted with hooray emoji

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 14, 2024
@Bibo-JoshiBibo-Joshi added 🔌 enhancementpr description: enhancement and removed enhancement labelsNov 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@harshil21harshil21harshil21 requested changes

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

Assignees
No one assigned
Labels
🔌 enhancementpr description: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] tool for translating unicode offsets to utf-16 offsets of MessageEntity
3 participants
@Antares0982@Bibo-Joshi@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp