Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

API 7.4 Message effects#4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
harshil21 merged 2 commits intoapi-7.4fromapi-7.4-msg-effect
May 29, 2024
Merged

API 7.4 Message effects#4278

harshil21 merged 2 commits intoapi-7.4fromapi-7.4-msg-effect
May 29, 2024

Conversation

harshil21
Copy link
Member

@harshil21harshil21 commentedMay 28, 2024
edited
Loading

Checklist

  • Added.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION or.. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s
  • Checked theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of theStability Policy

  • New classes:

    • Addedself._id_attrs and corresponding documentation
    • __init__ acceptsapi_kwargs as kw-only
  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that acceptchat/user_id
    • In :class:~telegram.Message for all methods that acceptchat_id andmessage_id
    • For new :class:~telegram.Message shortcuts: Addeddo_quote argument if methods acceptsreply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Add new message types to :attr:telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to_extbot.py
    • Added or updatedbot_methods.rst
    • Updated the Bot API version number in all places:README.rst andREADME_RAW.rst (including the badge), as well astelegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept areply_markup in some form or have a return type that is/contains :class:~telegram.Message

@harshil21harshil21 changed the base branch frommaster torm-api-7.3-deprMay 28, 2024 14:58
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@harshil21harshil21 changed the base branch fromrm-api-7.3-depr toapi-7.4May 28, 2024 14:59
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM :) merge at will

return bool(message.effect_id)


EFFECT_ID = _EffectId(name="filters.EFFECT_ID")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just an idea: allow filtering for specific effects? Dont strictly need that, also not in this PR, just mentioning

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the id is probably a long string so I don't think it makes much sense?

@harshil21harshil21 added the ⚙️ bot-apiaffected functionality: bot-api labelMay 29, 2024
@harshil21harshil21 merged commit9a01a56 intoapi-7.4May 29, 2024
19 of 22 checks passed
@harshil21harshil21 deleted the api-7.4-msg-effect branchMay 29, 2024 20:26
harshil21 added a commit that referenced this pull requestMay 30, 2024
@Bibo-JoshiBibo-Joshi mentioned this pull requestJun 1, 2024
25 tasks
Bibo-Joshi added a commit that referenced this pull requestJun 3, 2024
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@harshil21@Bibo-Joshi

[8]ページ先頭

©2009-2025 Movatter.jp