Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

API 7.4#4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 8 commits intomasterfromapi-7.4
Jun 3, 2024
Merged

API 7.4#4276

Bibo-Joshi merged 8 commits intomasterfromapi-7.4
Jun 3, 2024

Conversation

harshil21
Copy link
Member

@harshil21harshil21 commentedMay 28, 2024
edited by Bibo-Joshi
Loading

Central PR which will gather all PRs from api-7.4-feature

Closes#4275 .

Checklist

  • Added.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION or.. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s
  • Checked theStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of theStability Policy

  • New classes:

    • Addedself._id_attrs and corresponding documentation
    • __init__ acceptsapi_kwargs as kw-only
  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that acceptchat/user_id
    • In :class:~telegram.Message for all methods that acceptchat_id andmessage_id
    • For new :class:~telegram.Message shortcuts: Addeddo_quote argument if methods acceptsreply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Add new message types to :attr:telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to_extbot.py
    • Added or updatedbot_methods.rst
    • Updated the Bot API version number in all places:README.rst andREADME_RAW.rst (including the badge), as well astelegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept areply_markup in some form or have a return type that is/contains :class:~telegram.Message

rrr2rrr reacted with thumbs up emoji
@harshil21harshil21 added the ⚙️ bot-apiaffected functionality: bot-api labelMay 28, 2024
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Base automatically changed fromrm-api-7.3-depr tomasterMay 29, 2024 17:59
@harshil21
Copy link
MemberAuthor

not sure whytest_meta is failing on 3.12 (setuptools is missing somehow), probably some kind of caching issue?

@Bibo-Joshi
Copy link
Member

@harshil21 Its failing on master as well. Maybe we'll have to ensure installing setup tools in the CI

Copy link
Member

@PoolitzerPoolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

.

@@ -4890,7 +4994,7 @@ async def send_invoice(
a maximum tip of US$ 1.45 pass ``max_tip_amount = 145``. See the exp parameter in
`currencies.json <https://core.telegram.org/bots/payments/currencies.json>`_, it
shows the number of digits past the decimal point for each currency (2 for the
majority of currencies). Defaults to ``0``.
majority of currencies). Defaults to ``0``. Not supported for payment in |tg_stars|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
majorityofcurrencies).Defaultsto``0``.Notsupportedforpaymentin|tg_stars|
majorityofcurrencies).Defaultsto``0``.Notsupportedforpaymentin|tg_stars|.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yea that period takes it over 100 chars that's why I didn't put it lmao

pay (:obj:`bool`, optional): Specify :obj:`True`, to send a Pay button. This type of button
**must** always be the **first** button in the first row and can only be used in
invoice messages.
be launched when the user presses the button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
belaunchedwhentheuserpressesthebutton
belaunchedwhentheuserpressesthebutton.

shipping method.
address to complete the order. Ignored for payments in |tg_stars|.
need_shipping_address (:obj:`bool`, optional): Pass :obj:`True`, if you require the
user's shipping address to complete the order. Ignored for payments in |tg_stars|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
user'sshippingaddresstocompletetheorder.Ignoredforpaymentsin|tg_stars|
user'sshippingaddresstocompletetheorder.Ignoredforpaymentsin|tg_stars|.

@Bibo-JoshiBibo-Joshi merged commitcf72849 intomasterJun 3, 2024
25 checks passed
@Bibo-JoshiBibo-Joshi deleted the api-7.4 branchJune 3, 2024 17:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@PoolitzerPoolitzerPoolitzer requested changes

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] API 7.4
3 participants
@harshil21@Bibo-Joshi@Poolitzer

[8]ページ先頭

©2009-2025 Movatter.jp