Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support Python 3.13 beta#4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 12 commits intomasterfrompy13-beta
Jun 18, 2024
Merged

Support Python 3.13 beta#4253

Bibo-Joshi merged 12 commits intomasterfrompy13-beta
Jun 18, 2024

Conversation

harshil21
Copy link
Member

@harshil21harshil21 commentedMay 11, 2024•
edited
Loading

We should probably wait forcffi to release their new version to target 3.13, otherwise passport related functionality won't work. Tracking:python-cffi/cffi#23,python-cffi/cffi#71

Bibo-Joshi reacted with hooray emoji
@harshil21harshil21 added the 🔗 pythonrelated technology: python labelMay 11, 2024
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

@harshil21harshil21 added the 📋 do-not-merge-yetwork status: do-not-merge-yet labelMay 11, 2024
@harshil21
Copy link
MemberAuthor

If possible we should do#4129 before this is merged so it's easier to changesetup.py.test_meta fails on 3.13 because of the change tolocals() -https://docs.python.org/3.13/library/functions.html#locals. I don't want to change that part yet because I don't want to potentially break the release

Bibo-Joshi reacted with eyes emoji

@harshil21
Copy link
MemberAuthor

I don't want to change that part yet because I don't want to potentially break the release

ironically if we don't merge this, then all ptb installations on py 3.13 will fail by default. And we don't have python version specific wheels so we can build it on another version and it should be good to go.

uses pre-release of cffi 1.17.0 since they don't plan to release the full version until 3.13 rc1

@harshil21harshil21 removed the 📋 do-not-merge-yetwork status: do-not-merge-yet labelJun 16, 2024
@harshil21
Copy link
MemberAuthor

Merged master so we should be good to go. Also verified thatpip install .[passport] correctly installs cffi 1.17.0 on python 3.13.

Not sure why type completeness is unhappy. All ruff did was remove some quotes around the annotation and that failed this test apparently.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi, thanks for the updates :) I left a bunch of comments🙆‍♂️

harshil21and others added2 commitsJune 17, 2024 13:59
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, then, thanks for the work :) Anyhting to add from your side or should I merge?

@harshil21
Copy link
MemberAuthor

All good from my side!

Bibo-Joshi reacted with hooray emoji

@Bibo-JoshiBibo-Joshi merged commit9ce0f49 intomasterJun 18, 2024
27 checks passed
@Bibo-JoshiBibo-Joshi deleted the py13-beta branchJune 18, 2024 20:25
@@ -106,7 +106,7 @@ def __init__(self) -> None:

self._application: Optional[weakref.ReferenceType[Application]] = None
self._executor = AsyncIOExecutor()
self.scheduler: AsyncIOScheduler = AsyncIOScheduler(**self.scheduler_configuration)
self.scheduler:"AsyncIOScheduler" = AsyncIOScheduler(**self.scheduler_configuration)
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ruff complains about this for me locally (i'm on py 3.13 so that's possibly why now)

@harshil21
Copy link
MemberAuthor

also forget to mention that for some reason mypy segfaults on my build of python 3.13b1. Does anyone else have the same issue?

Bibo-Joshi reacted with eyes emoji

@Bibo-Joshi
Copy link
Member

Did not try yet ...

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

Assignees
No one assigned
Labels
🔗 pythonrelated technology: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@harshil21@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp