Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix error withLiteral, causing tests/docs to fail#3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@lemontree210
Copy link
Member

Fix test failure caused by introduction ofLiteral types.

@lemontree210lemontree210 added bug 🐛 ⚙️ documentationaffected functionality: documentation labelsJun 18, 2023
@lemontree210lemontree210 self-assigned thisJun 18, 2023
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

docs successfully built locally for me

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you maybe extend the CSI comment about why Literal needs to be treated here as well?

@lemontree210
Copy link
MemberAuthor

Can you maybe extend the CSI comment about why Literal needs to be treated here as well?

To me, it looks rather natural in this sequence and it might look a bit strange if I explain only theLiteral bit:

("<class 'typing._GenericAlias'>","<class 'types.GenericAlias'>","<class 'typing._LiteralGenericAlias'>",        )

They're all Generic aliases.

OTOH, it's hard to imagine that we'll ever put a telegram class inside a literal. Something like:

Persistence=Literal["PicklePersistence","DictPersistence"]

In this case, I could just create a separate condition forLiteral and skip it altogether without even checking what's inside.

Bibo-Joshi reacted with thumbs up emoji

@Bibo-JoshiBibo-Joshi merged commit27a8683 intodrop-py-37Jun 19, 2023
@Bibo-JoshiBibo-Joshi deleted the fix-admonition-inserter-after-adding-literals branchJune 19, 2023 19:46
Seonzzang2 added a commit to Seonzzang2/python-telegram-bot that referenced this pull requestJun 20, 2023
@Bibo-JoshiBibo-Joshi mentioned this pull requestJun 25, 2023
17 tasks
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 27, 2023
@Bibo-JoshiBibo-Joshi added 🔌 bugpr description: bug and removed bug 🐛 labelsNov 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

@harshil21harshil21harshil21 approved these changes

Assignees

@lemontree210lemontree210

Labels

🔌 bugpr description: bug⚙️ documentationaffected functionality: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lemontree210@Bibo-Joshi@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp