- Notifications
You must be signed in to change notification settings - Fork5.9k
fix error withLiteral, causing tests/docs to fail#3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix error withLiteral, causing tests/docs to fail#3764
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
docs successfully built locally for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you maybe extend the CSI comment about why Literal needs to be treated here as well?
To me, it looks rather natural in this sequence and it might look a bit strange if I explain only the ("<class 'typing._GenericAlias'>","<class 'types.GenericAlias'>","<class 'typing._LiteralGenericAlias'>", ) They're all Generic aliases. OTOH, it's hard to imagine that we'll ever put a telegram class inside a literal. Something like: Persistence=Literal["PicklePersistence","DictPersistence"] In this case, I could just create a separate condition for |
Fix test failure caused by introduction of
Literaltypes.