Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Passname toasyncio.create_task#3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 7 commits intodrop-py-37fromasyncio-task-names
Jun 29, 2023
Merged

Conversation

@harshil21
Copy link
Member

Closes#3733

I couldn't test thename inJob._run since that task is instantly awaited (why?)

@harshil21harshil21 added enhancement 🔗 pythonrelated technology: python labelsJun 17, 2023
@harshil21harshil21 added this to thev20.4 milestoneJun 17, 2023
@harshil21harshil21 linked an issueJun 17, 2023 that may beclosed by this pull request
@Bibo-Joshi
Copy link
Member

@harshil21 IISC the point is that the call to application.create_task ensures that the job will be awaited on shutdown...

by using Event based test than a timed one
@harshil21harshil21 added the 📋 pending-reviewwork status: pending-review labelJun 20, 2023
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! :) Left a few suggestions below. Sorry for the brief wording, I'm not at a keyboard...

harshil21 reacted with thumbs up emoji
@harshil21harshil21 added the 📋 pending-mergework status: pending-merge labelJun 28, 2023
@Bibo-JoshiBibo-Joshi merged commit59a932a intodrop-py-37Jun 29, 2023
@Bibo-JoshiBibo-Joshi deleted the asyncio-task-names branchJune 29, 2023 15:47
@Bibo-JoshiBibo-Joshi removed the 📋 pending-mergework status: pending-merge labelJun 29, 2023
@Bibo-JoshiBibo-Joshi mentioned this pull requestJun 29, 2023
17 tasks
Bibo-Joshi added a commit that referenced this pull requestJun 29, 2023
…#3764,#3762,#3759)Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>Co-authored-by: Luca Bellanti <luca.bellanti@gmail.com>Co-authored-by: thefunkycat <104379699+thefunkycat@users.noreply.github.com>Co-authored-by: Aditya Yadav <69784758+clot27@users.noreply.github.com>Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
clot27 added a commit that referenced this pull requestJul 3, 2023
…#3764,#3762,#3759)Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>Co-authored-by: Luca Bellanti <luca.bellanti@gmail.com>Co-authored-by: thefunkycat <104379699+thefunkycat@users.noreply.github.com>Co-authored-by: Aditya Yadav <69784758+clot27@users.noreply.github.com>Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 7, 2023
@Bibo-JoshiBibo-Joshi added 🔌 enhancementpr description: enhancement and removed enhancement labelsNov 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

Assignees

No one assigned

Labels

🔌 enhancementpr description: enhancement🔗 pythonrelated technology: python

Projects

None yet

Milestone

v20.4

Development

Successfully merging this pull request may close these issues.

Adopt Py3.8+ features: Names for asyncio tasks

3 participants

@harshil21@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp