Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Make use of@final,Final andLiteral#3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 3 commits intodrop-py-37frompy-3.8-typing
Jun 17, 2023
Merged

Conversation

@Bibo-Joshi
Copy link
Member

Closes#3735

  • Mostly changesClassVar toFinal for all constants
  • Adds some limited usage of the@final decorator forBase{UpdateProcessor, Request}
  • UsesLiteral for thehttp_version argument ofHTTPXRequest. Otherwise,Literal is not used due toLiteral of enum values python/typing#781

If there are more places, where@final orLiteral are useful, please do point them out :)

@Bibo-JoshiBibo-Joshi added ⚙️ type-hintingaffected functionality: type-hinting 🔗 pythonrelated technology: python labelsJun 12, 2023
Copy link
Member

@lemontree210lemontree210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't have the required in-depth knowledge to suggest more cases of@final that may have been missed

@harshil21harshil21 added this to thev20.4 milestoneJun 16, 2023
@Bibo-JoshiBibo-Joshi merged commit9181369 intodrop-py-37Jun 17, 2023
@Bibo-JoshiBibo-Joshi deleted the py-3.8-typing branchJune 17, 2023 07:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lemontree210lemontree210lemontree210 approved these changes

@harshil21harshil21Awaiting requested review from harshil21

Assignees

No one assigned

Labels

🔗 pythonrelated technology: python⚙️ type-hintingaffected functionality: type-hinting

Projects

None yet

Milestone

v20.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Bibo-Joshi@lemontree210@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp