Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add walrus operator wherever possible#3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@thefunkycat
Copy link
Contributor

@thefunkycatthefunkycat commentedJun 6, 2023•
edited
Loading

Solves#3734

I have tried to add the walrus operator wherever possible.

I went through most files.
There were a couple more instances I found where I could have added it, but it was unnecessary and would not have necessarily improved readability or code quality.

I was more lenient when it came to adding the walrus operator to tests

@thefunkycat
Copy link
ContributorAuthor

@Bibo-Joshi@clot27 is there a reason thetest_send_animation_url_file() andtest_send_all_args() are failing? is this me? or is this a pre existing issue

@Bibo-Joshi
Copy link
Member

Thanks for the PR! The tests are failing on some other PRs since yesterday, too. Seems like something changed in the TG servers. We'll have to investigate.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The failing tests seem to have recovered. Now onlyTestInlineQueryHandler.test_context_pattern is failing. I guess that's due to your changes though TBH I don't really see a flaw in those … Would you mind double check ing that?

thefunkycat reacted with thumbs up emoji
@thefunkycat
Copy link
ContributorAuthor

thefunkycat commentedJun 8, 2023•
edited
Loading

@Bibo-Joshi should be fixed now :)

Edit: oof the tests still fail but this is related to submitting the test coverage, all the tests pass. so not the code.

@Bibo-JoshiBibo-Joshi merged commita1c2fe7 intopython-telegram-bot:drop-py-37Jun 8, 2023
@Bibo-Joshi
Copy link
Member

Thank you very much for the nice contribution :)

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thefunkycat@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp