Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove Python 3.7 workaround forPicklePersistence#3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 5 commits intodrop-py-37frompp-workaround
Jun 9, 2023

Conversation

@harshil21
Copy link
Member

Closes#3732

I don't think anything in tests need to change?

@harshil21harshil21 added 🛠 refactorchange type: refactor 🔗 pythonrelated technology: python labelsJun 3, 2023
@harshil21harshil21 added this to thev20.4 milestoneJun 3, 2023
@harshil21harshil21 linked an issueJun 4, 2023 that may beclosed by this pull request
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess the tests don't have explicit cases for py 3.7, right. Howover, I am wondering if it is possible to pickle data in 3.7 and unpickle it in 3.8 🤔 Could you check?

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes LGTM 👍 Did you have any chance to test if py37-pickled files can be loaded in py38?

harshil21 reacted with thumbs up emoji
@Bibo-JoshiBibo-Joshi merged commit9d3345c intodrop-py-37Jun 9, 2023
@Bibo-JoshiBibo-Joshi deleted the pp-workaround branchJune 9, 2023 16:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 17, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

Assignees

No one assigned

Labels

🔗 pythonrelated technology: python🛠 refactorchange type: refactor

Projects

None yet

Milestone

v20.4

Development

Successfully merging this pull request may close these issues.

Adopt Py3.8+ features: Drop workaround inPicklePersistence

3 participants

@harshil21@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp