Fixed a few warning categories that were missed in API 6.6.
Unifies warning handling inBot andExtBot, ensuring that the stacklevel is correct for both
adds missing tests & modifies existing ones

TODO:

Update all warning tests to also check the category
Update tests to double check stacklevel in ExtBot vs Bot

Update a few warning categories

422c3b5

Bibo-Joshi self-assigned this

Apr 21, 2023

Bibo-Joshi added enhancement ⚙️ testsaffected functionality: tests labels

Apr 21, 2023

Get started on updating tests

e43b797

harshil21 reviewed

Apr 21, 2023

View reviewed changes

Copy link

Member

harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice catches

tests/test_bot.py OutdatedShow resolvedHide resolved

tests/ext/test_picklepersistence.py OutdatedShow resolvedHide resolved

tests/ext/test_conversationhandler.py OutdatedShow resolvedHide resolved

Bibo-Joshi added3 commits

April 22, 2023 18:25

review

f9888b6

Fix existing tests & try to make warnings in Bot & ExtBot uniform

5e5f870

Add/extend deprecation tests

08db55e

Bibo-Joshi marked this pull request as ready for review

April 22, 2023 21:13

Bibo-Joshi requested review fromharshil21 andlemontree210

April 22, 2023 21:13

fix tests

c85dd4e

lemontree210 requested changes

Apr 23, 2023

View reviewed changes

Copy link

Member

lemontree210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm obviously out of my depth here, but one typo I did catch! :)

telegram/_bot.py OutdatedShow resolvedHide resolved

tests/auxil/deprecations.py OutdatedShow resolvedHide resolved

Copy link

MemberAuthor

Bibo-Joshi commentedApr 23, 2023

Just a related note: stackleveling will get way more fun soon :Dhttps://github.com/python-telegram-bot/python-telegram-bot/projects/8#card-88970053

Review:

22a1883

* Fix typo* Make sure to only use the local information on stacklevel

harshil21 reviewed

Apr 24, 2023

View reviewed changes

Copy link

Member

harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

much more extensive testing, I like it

telegram/_bot.py OutdatedShow resolvedHide resolved

tests/_files/test_animation.pyShow resolvedHide resolved

Fix a typo

92c4d08

Bibo-Joshi changed the title~~Improve Warning Categories~~Improve Warning Categories & Stacklevels

Apr 24, 2023

Copy link

MemberAuthor

Bibo-Joshi commentedApr 24, 2023

While working on#3673 I noticed that the subscription access to attributes ofTelegramObject can mess with the stacklevel. Becausemessage["text_markdown"] callsmessage.__getitem__("text_markdown") that's one more function call meaning that the warning will originate from_telegramobject.py instead of the user code. I guess the only workaround for that would be to catch & reraise all warnings in__getitem__ and that's not really clean … IMO the use case is small enough to ignore. Just wanted to note it in the context of this PR :)