Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Customized concurrent handling#3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 33 commits intomasterfromcustomized-concurrent-handling
Jun 2, 2023

Conversation

clot27
Copy link
Member

@clot27clot27 commentedApr 9, 2023•
edited by Bibo-Joshi
Loading

Closes#3509 when done.

Checklist for PRs

  • Added.. versionadded:: version,.. versionchanged:: version or.. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard
  • [ ] Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s

@clot27clot27 marked this pull request as draftApril 9, 2023 17:37
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the nice PR@clot27 !
IMO it covers the contents of#3509 pretty well and the overvall logic looks good :) I left some comments already though I'll ofc do a proper review again once it's out of draft status .

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

initial review. Will review again after tests are added, implementation looks ok to me

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the updates! This will come out great :) I left a bunch of new comments, but nothing major IMO.

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

more comments. But looking much more refined now 👍🏽

@clot27clot27 marked this pull request as ready for reviewApril 25, 2023 15:01
@Bibo-JoshiBibo-Joshi added enhancement ℹ️ needs-wiki-updateinformation: needs-wiki-update labelsMay 17, 2023
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the new updates! I left smaller comments :) Also the docs build is failing …

Regarding the unit tests on the update processors: TBH I don't see them going in a right direction and I'm not sure how I can explain better what should be covered. I will try and write some tests myself, but please do feel free to ask anything about that if you have questions :)

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM :)@harshil21 do you have anything to add?

After merge, the dev-wiki should be updated to

  • elaborate on the new processor on the page on concurrency
  • mention theBaseUpdateProcessor on the architecture page. This would be a good chance to convert the graphic to a mermaid diagram

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

final review. Looks much more refined and ready. Good job@clot27. Just some tiny errors caught:

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice upgrade!

@Bibo-JoshiBibo-Joshi merged commitbf54599 intomasterJun 2, 2023
@Bibo-JoshiBibo-Joshi deleted the customized-concurrent-handling branchJune 2, 2023 16:17
@Bibo-Joshi
Copy link
Member

Big thanks to@clot27 for your work and also your patience! 👏

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 10, 2023
@Bibo-JoshiBibo-Joshi added 🔌 enhancementpr description: enhancement and removed enhancement labelsNov 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
🔌 enhancementpr description: enhancementℹ️ needs-wiki-updateinformation: needs-wiki-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Customizing concurrent handling of updates
3 participants
@clot27@Bibo-Joshi@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp