Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

API 6.3 for V13#3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 12 commits intov13.xfromv13.x_api6.3
Dec 6, 2022
Merged

API 6.3 for V13#3392

Bibo-Joshi merged 12 commits intov13.xfromv13.x_api6.3
Dec 6, 2022

Conversation

@Poolitzer
Copy link
Member

Currently not implemented are the changed/new tests.

I already implemented#3381, if there was another fix related to the 6.3 changes from#3346 I missed that.

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

@harshil21harshil21 added ⚙️ bot-apiaffected functionality: bot-api 🛠 backportchange type: backport labelsNov 25, 2022
@harshil21harshil21 added this to the13.15 milestoneNov 25, 2022
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I admire your patience with v13!

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

great work!

@harshil21harshil21 added the 📋 pending-replywork status: pending-reply labelNov 27, 2022
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TBH I didn't go through all changed lines again and also didn't read every single test, but my previous comments where addressed nicely and everything looks in order :) LGTM! Thanks for the PR, Pool!

PS: I'm going to ignore DS on v13 and codacy just complains about this branch not being analyzed - which is fine with me, since it will die soon 🥳

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I also did have a rough look at it, and it looks good to me as well

@Bibo-JoshiBibo-Joshi merged commitd6c6cc2 intov13.xDec 6, 2022
@Bibo-JoshiBibo-Joshi deleted the v13.x_api6.3 branchDecember 6, 2022 09:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsDec 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

@harshil21harshil21harshil21 approved these changes

Assignees

No one assigned

Labels

🛠 backportchange type: backport⚙️ bot-apiaffected functionality: bot-api📋 pending-replywork status: pending-reply

Projects

None yet

Milestone

13.15

Development

Successfully merging this pull request may close these issues.

4 participants

@Poolitzer@Bibo-Joshi@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp