create new classesForumTopic,ForumTopicCreated, empty classes
ForumTopicClosed,ForumTopicReopened
add arguments and attributes toMessage:forum_topic_created,forum_topic_closed,forum_topic_reopened
update docs
add tests
- to_dict,__eq__ etc. for each class
- createForumTopic
- editForumTopic
- closeForumTopic
- reopenForumTopic
- deleteForumTopic (I test it in the fixture)
- unpinAllForumTopicMessages (test created but triggerstelegram.error.BadRequest: Chat_not_modified.)
- getForumTopicIconStickers
add filters

lemontree210 added4 commits

November 11, 2022 11:20

copy-paste Poolitzer'stest_forum.py, move test fromtest_bot.py

374563d

refactor(test_forum.py): add fixture to create and delete topic

b5211d8

merge api_6.3_update

c24efa2

create classesForumTopic,ForumTopic..., 1st test

726b6ab

Copy link

MemberAuthor

lemontree210 commentedNov 11, 2022•
edited
Loading

Actually, again, maybe the tests are worth adding when the methods are there, so it might make sense to review this as it is, then hopefully merge, and then we'll add tests with real methods.

lemontree210 marked this pull request as ready for review

November 11, 2022 14:41

lemontree210 marked this pull request as draft

November 11, 2022 14:46

harshil21 added this to thev20.0a5 milestone

Nov 11, 2022

harshil21 added the ⚙️ bot-apiaffected functionality: bot-api label

Nov 11, 2022

add tests for service message classes, fixde_json() in `ForumTopic…

7d77ae9

…Created`+ change docstring for the modulewill add tests for `ForumTopic` later on

lemontree210 commented

Nov 12, 2022

View reviewed changes

telegram/_forumtopic.py OutdatedShow resolvedHide resolved

lemontree210 added2 commits

November 12, 2022 14:39

minor: remove TODO after comment in review

5c0a2e8

add tests andde_json() forForumTopic

deaacfb

lemontree210 commented

Nov 12, 2022

View reviewed changes

telegram/_forumtopic.py OutdatedShow resolvedHide resolved

lemontree210 marked this pull request as ready for review

November 12, 2022 12:04

harshil21 reviewed

Nov 12, 2022

View reviewed changes

docs/source/telegram.rst OutdatedShow resolvedHide resolved

telegram/_forumtopic.py OutdatedShow resolvedHide resolved

telegram/_message.py OutdatedShow resolvedHide resolved

telegram/_message.pyShow resolvedHide resolved

tests/test_forum.py OutdatedShow resolvedHide resolved

telegram/_forumtopic.py OutdatedShow resolvedHide resolved

lemontree210 added8 commits

November 13, 2022 13:44

fix(typos inmessage.py):TopicForum ->ForumTopic

b627a9c

fix(_forumtopic.py): rmde_json(), replace{} withNone in test

5fe81c1

`TelegramObject`'s `de_json()` will work fineif `None` is passed instead of empty dict

fix(telegram.rst): reorder alphabetically

d40e8a0

fix(message.py): add "forum_topic_closed", "_reopened" tode_json()

417bd26

fix(class docstrings), optional): ->): Optional. in attrs section

e12a8ff

refactor(test_forum.py) add/change fixtures

7328f43

2 tests copied/pasted from another branch still fail

fix(ForumTopic): make__eq__ check all required args (+icon_color)

99095c4

Merge remote-tracking branch 'origin/api_6.3_update' into new_classes…

1be6f67

…_for_api_6.3

Copy link

MemberAuthor

lemontree210 commentedNov 14, 2022

This seems ready to be merged if there are no other comments.

harshil21 requested changes

Nov 14, 2022

View reviewed changes

Copy link

Member

harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now that all 7 forum methods have been implemented upstream,test_forum.py should be updated to test that.

Also we can add filters for the new status messages (ForumTopicCreated, etc). Seefilters.StatusUpdate as examples on how to add them, it's fairly straightforward.

tests/test_forum.py OutdatedShow resolvedHide resolved

Bibo-Joshiand others added4 commits

November 15, 2022 09:14

Merge branch 'api_6.3_update' into new_classes_for_api_6.3

0d3d1c0

# Conflicts:#docs/source/telegram.rst#telegram/_message.py

re-add new classes to toctree

46d24bc

Merge remote-tracking branch 'origin/api_6.3_update' into new_classes…

f51caf3

…_for_api_6.3

fix(Bot.create_forum_topic): returnForumTopic; change test fixture

f958cbc

lemontree210 added4 commits

November 16, 2022 14:51

fix(Bot.create_forum_topic): make 2 attrs optional, tweak docstring

759816f

* `icon_color` and `icon_custom_emoji_id` must be optional* remove link to `Message.create_forum_topic`from docstring (there will be no such shortcut)

fix existing test that was failing

d323c7f

add tests forBot.create_forum_topic()

1b52d1c

rename fixture, replace dummy emoji ID with real one from fixture

011fcfa

Copy link

MemberAuthor

lemontree210 commentedNov 17, 2022•
edited
Loading

I'm having trouble adding a test forForumTopicCreated. My idea is that I should create a topic, then get updates, check the lastMessage and make sure it contains a service message inforum_topic_created attribute with the correct topic name. Somehow it doesn't work though, which maybe depends on howbot fixture works. (I do get service messages, but old ones.)

I tried to see how it was done for other classes representing service messages, but tests for classes likeVideoChatScheduled,MessageAutoDeleteTimerChanged and others only seem to test slots, equality etc., but not the fact of the service message actually being issued. So I'm struggling to find any relevant examples to follow here :)