Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

API 6.3#3346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 34 commits intomasterfromapi_6.3_update
Nov 22, 2022
Merged

API 6.3#3346

Bibo-Joshi merged 34 commits intomasterfromapi_6.3_update
Nov 22, 2022

Conversation

harshil21
Copy link
Member

@harshil21harshil21 commentedNov 6, 2022
edited by Bibo-Joshi
Loading

Gathering all commits/fixes/PRs for the new and big 6.3 update.

  • Update tests for new forum methods - seehere
  • revert changes to the test config

Checklist for PRs

  • Added.. versionadded:: version,.. versionchanged:: version or.. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Addedself._id_attrs and corresponding documentation
    • __init__ accepts**_kwargs
  • Added new shortcuts:

    • InChat &User for all methods that acceptchat/user_id
    • InMessage for all methods that acceptchat_id andmessage_id
    • For newMessage shortcuts: Addedquote argument if methods acceptsreply_to_message_id
    • InCallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants attelegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Add new message types toMessage.effective_attachment
    • Added new handlers for new update types
      • Add the handlers to the warning loop in theConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added or updatedbot_methods.rst
    • Updated the Bot API version number in all places:README.rst andREADME_RAW.rst (including the badge), as well astelegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data intg.ext.Bot for new methods that either accept areply_markup in some form or have a return type that is/containstelegram.Message

@harshil21harshil21 added the ⚙️ bot-apiaffected functionality: bot-api labelNov 6, 2022
@harshil21harshil21 added this to thev20.0a5 milestoneNov 6, 2022
@harshil21harshil21 linked an issueNov 6, 2022 that may beclosed by this pull request
13 tasks
Bibo-Joshiand others added17 commitsNovember 6, 2022 22:20
# Conflicts:#tests/test_bot.py
# Conflicts:#telegram/_bot.py#telegram/_message.py
Co-authored-by: Aditya Yadav <adityayadav11082@gmail.com>Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
…icClosed`, `ForumTopicReopened` (#3356)Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi
Copy link
Member

Requesting reviews fromeveryone 🕺 Will try to review sometime this weekend
Smaller stuff can be pushed directly into this branch by everyone IMO. For things that you feel like they need discussion, leave a comment :)

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

the TODO was asking about whether we should testa `str` identifier of a chat (right now only `int`is tested)It was agreed that additional tests were not neededand we will trust Telegram's behaviour
colors are automatically converted to `int`.User should be able to see that we mean HEX colorslisted in Telegram API
Copy link
Member

@lemontree210lemontree210 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Obviously, given my lack of in-depth knowledge, this is notmostly nitpicking: this isonly nitpicking 😄

Copy link
Member

@lemontree210lemontree210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes suggested based on my work on#3351 . I can implement the changes myself, should there be no objections

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Went through the code (but skipped the tests). Only have two comments :)

Copy link
Member

@PoolitzerPoolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Didnt see an issue here, gj usclaps on the back

Copy link
Member

@clot27clot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@Bibo-JoshiBibo-Joshi merged commitcaacafa intomasterNov 22, 2022
@Bibo-JoshiBibo-Joshi deleted the api_6.3_update branchNovember 22, 2022 09:43
@PoolitzerPoolitzer mentioned this pull requestNov 25, 2022
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@lemontree210lemontree210lemontree210 requested changes

@PoolitzerPoolitzerPoolitzer approved these changes

@clot27clot27clot27 approved these changes

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
v20.0a5
Development

Successfully merging this pull request may close these issues.

[Feature] Bot API 6.3 update
5 participants
@harshil21@Bibo-Joshi@Poolitzer@lemontree210@clot27

[8]ページ先頭

©2009-2025 Movatter.jp