- Notifications
You must be signed in to change notification settings - Fork5.9k
API 6.3#3346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
API 6.3#3346
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…_topic_message` to `Message` (#3345)
# Conflicts:#tests/test_bot.py
# Conflicts:#telegram/_bot.py#telegram/_message.py
Co-authored-by: Aditya Yadav <adityayadav11082@gmail.com>Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>
…icClosed`, `ForumTopicReopened` (#3356)Co-authored-by: Hinrich Mahler <22366557+Bibo-Joshi@users.noreply.github.com>Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Bibo-Joshi commentedNov 18, 2022
Requesting reviews fromeveryone 🕺 Will try to review sometime this weekend |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
the TODO was asking about whether we should testa `str` identifier of a chat (right now only `int`is tested)It was agreed that additional tests were not neededand we will trust Telegram's behaviour
colors are automatically converted to `int`.User should be able to see that we mean HEX colorslisted in Telegram API
lemontree210 left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Obviously, given my lack of in-depth knowledge, this is notmostly nitpicking: this isonly nitpicking 😄
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
lemontree210 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changes suggested based on my work on#3351 . I can implement the changes myself, should there be no objections
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Bibo-Joshi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Went through the code (but skipped the tests). Only have two comments :)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Poolitzer left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Didnt see an issue here, gj usclaps on the back
clot27 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
# Conflicts:#docs/substitutions/global.rst
Uh oh!
There was an error while loading.Please reload this page.
Gathering all commits/fixes/PRs for the new and big 6.3 update.
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Added myself alphabetically toAUTHORS.rst(optional)__all__sIf the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrsand corresponding documentation__init__accepts**_kwargsAdded new shortcuts:
Chat&Userfor all methods that acceptchat/user_idMessagefor all methods that acceptchat_idandmessage_idFor newMessageshortcuts: Addedquoteargument if methods acceptsreply_to_message_idInCallbackQueryfor all methods that accept eitherchat_idandmessage_idorinline_message_idIf relevant:
telegram.constantsand shortcuts to them as class variablesAdd new message types toMessage.effective_attachmentAdded new handlers for new update typesAdd the handlers to the warning loop in theConversationHandlerbot_methods.rstREADME.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSIONAdded logic for arbitrary callback data intg.ext.Botfor new methods that either accept areply_markupin some form or have a return type that is/containstelegram.Message