Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

addmessage_thread_id param to methods,message_thread_id andis_topic_message toMessage#3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

lemontree210
Copy link
Member

@lemontree210lemontree210 commentedNov 6, 2022•
edited
Loading

addresses#3340

  • Addmessage_thread_id to methods inBot andExtBot
    • add parameter
    • add docstrings with.. versionadded:: version
    • add argument to a call tosend_message or item todata
  • Add method to shortcuts (Chat,User...)
  • Create new or adapted existing unit tests -will only be possible when class for topics is created

* haven't added this param to shortcuts yet* testing doesn't seem to be possible beforeForumTopic class is implemented
Copy link
Member

@PoolitzerPoolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

@lemontree210lemontree210 changed the titleaddmessage_thread_id parameteraddmessage_thread_id param to methods,message_thread_id andis_topic_message toMessageNov 7, 2022
@lemontree210
Copy link
MemberAuthor

Hey guys, do you maybe think that we should merge this intoapi_6.3_update and then I'd branch off again when it becomes possible to add tests with real methods and attributes?

@lemontree210lemontree210 marked this pull request as ready for reviewNovember 8, 2022 10:47
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One inquery, but the changes LGTM :) can be merged IMO

@Bibo-JoshiBibo-Joshi merged commit3e8aa6e intoapi_6.3_updateNov 9, 2022
@Bibo-JoshiBibo-Joshi deleted the new_param_message_thread_id_3340 branchNovember 9, 2022 19:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@PoolitzerPoolitzerPoolitzer requested changes

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lemontree210@Bibo-Joshi@Poolitzer
[8]ページ先頭
©2009-2025 Movatter.jp