- Notifications
You must be signed in to change notification settings - Fork5.7k
Feat: Docstring changes + moving limit to constants#3343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
telegram/constants.py Outdated
| @@ -901,3 +901,18 @@ class WebhookLimit(IntEnum): | |||
| """:obj:`int`: Minimum length of the secret token.""" | |||
| MAX_SECRET_TOKEN_LENGTH = 256 | |||
| """:obj:`int`: Maximum length of the secret token.""" | |||
| class ChatLimits(IntEnum): | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IIRC we named verything else in singular, i.e.class <…>Limit(enum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You appear to be right
Also add it to the all variable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, can be merged IMO
This adds the two docstring changes, I took the opportunity to move the changed limit to constants. At least description can be added to the limit (e.g. in#3336), maybe even more, so I kept the Class name broad.