Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: add enum constants#3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lemontree210 wants to merge8 commits intopython-telegram-bot:masterfromlemontree210:enums-instead-of-literals-3107
Closed

refactor: add enum constants#3336

lemontree210 wants to merge8 commits intopython-telegram-bot:masterfromlemontree210:enums-instead-of-literals-3107

Conversation

lemontree210
Copy link
Member

@lemontree210lemontree210 commentedNov 5, 2022•
edited
Loading

addresses#3107

* add constants for `max_connections`* expand docstring for `secret_token`
@lemontree210lemontree210 changed the titlerefactor(Bot) add enum constants forBot.set_webhook()refactor(Bot) add enum constantsNov 5, 2022
@lemontree210lemontree210 changed the titlerefactor(Bot) add enum constantsrefactor: add enum constantsNov 5, 2022
@harshil21harshil21 added the ⚙️ documentationaffected functionality: documentation labelNov 5, 2022
* add limits for heading* add minimum proximity_alert_radius(as it is non-zero)* fix docstrings that link to HEADINGconstant twice instead of PROXIMITY_ALERT_RADIUS(and hence 360 was displayed instead of 100000)
@lemontree210
Copy link
MemberAuthor

Question regarding limits forLocation andsend_location: I know that in Telegram API itself most limits are only listed insendLocation and not inLocation, e.g.live_period andheading.

Should I list all the limits inLocation as well or do I stick to what's listed or not listed in Telegram API?

@harshil21
Copy link
Member

Should I list all the limits inLocation as well or do I stick to what's listed or not listed in Telegram API?

I think we should stick to TG API docs.

lemontree210 reacted with thumbs up emoji

@lemontree210lemontree210 mentioned this pull requestNov 8, 2022
8 tasks
lemontree210 added a commit that referenced this pull requestNov 8, 2022
as suggested in review for PR#3336,but in singular (rather than `...Limits`)to conform with review for#3343
@lemontree210
Copy link
MemberAuthor

closing this PR, all work moved to#3351 (with branches within same repo as opposed to fork)

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

@harshil21harshil21harshil21 left review comments

Assignees
No one assigned
Labels
⚙️ documentationaffected functionality: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lemontree210@harshil21@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp