Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

update: added deep link maximum character constant#3315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

BAcode-X
Copy link
Contributor

Based onTelegram API doc, the parameter can only be up to 64 characters long.

Checklist

- [ ] Added new constants at `telegram.constants`

@harshil21harshil21 added this to thev20.0b1 milestoneOct 30, 2022
@Poolitzer
Copy link
Member

Hi. You added the constant above the line where it says that "the constants above this line are tested", while not adding a test. I don't think this variable needs one (and it wouldn't be fun to write either), so just move it down.

BAcode-X reacted with thumbs up emoji

Copy link
Member

@PoolitzerPoolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@Bibo-JoshiBibo-Joshi merged commit55106d6 intopython-telegram-bot:masterNov 1, 2022
@Bibo-Joshi
Copy link
Member

Thank you for the contribution :)

BAcode-X reacted with thumbs up emoji

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsNov 8, 2022
@Bibo-JoshiBibo-Joshi added 🔌 enhancementpr description: enhancement and removed enhancement labelsNov 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@PoolitzerPoolitzerPoolitzer approved these changes

Assignees
No one assigned
Labels
🔌 enhancementpr description: enhancement
Projects
None yet
Milestone
v20.0a5
Development

Successfully merging this pull request may close these issues.

4 participants
@BAcode-X@Poolitzer@Bibo-Joshi@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp