Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

V13 API 6.2 implementation#3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 7 commits intov13.xfromv13-api6.2
Sep 4, 2022
Merged

V13 API 6.2 implementation#3203

Bibo-Joshi merged 7 commits intov13.xfromv13-api6.2
Sep 4, 2022

Conversation

Poolitzer
Copy link
Member

Checklist for PRs

  • Added.. versionadded:: version,.. versionchanged:: version or.. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Addedself._id_attrs and corresponding documentation
    • __init__ accepts**_kwargs
  • Added new shortcuts:

    • InChat &User for all methods that acceptchat/user_id
    • InMessage for all methods that acceptchat_id andmessage_id
    • For newMessage shortcuts: Addedquote argument if methods acceptsreply_to_message_id
    • InCallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants attelegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Add new message types toMessage.effective_attachment
    • Added new handlers for new update types
      • Add the handlers to the warning loop in theConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added or updatedbot_methods.rst
    • Updated the Bot API version number in all places:README.rst andREADME_RAW.rst (including the badge), as well astelegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data intg.ext.Bot for new methods that either accept areply_markup in some form or have a return type that is/containstelegram.Message

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fast PR!

  • test_official is complaining thatStickerSet.contains_masks is still present. Can you check how we handled such cases in the past?
  • DeepSource is complaining about two places where we could use f-strings. Feel free to improve, or just add a# skipcq: …

@harshil21harshil21 added this to thev13.14 milestoneAug 26, 2022
@harshil21harshil21 added the ⚙️ bot-apiaffected functionality: bot-api labelAug 26, 2022
@Bibo-Joshi
Copy link
Member

Thanks for the updates. I think I'm happy with the changes, then. I vote to ignore DS on this for the reasons mentioned inhttps://discuss.deepsource.io/t/improve-granular-setting-possibility-to-pin-a-deepsource-version/472.

@Bibo-JoshiBibo-Joshi merged commitdca596d intov13.xSep 4, 2022
@Bibo-JoshiBibo-Joshi deleted the v13-api6.2 branchSeptember 4, 2022 07:15
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi requested changes

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@neilarchie06neilarchie06neilarchie06 approved these changes

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
v13.14
Development

Successfully merging this pull request may close these issues.

4 participants
@Poolitzer@Bibo-Joshi@neilarchie06@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp