Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fixed Edit on github links for v13.x documentation#3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
harshil21 merged 6 commits intopython-telegram-bot:doc-fixes-v13fromjavad94:13.x-doc-fix
Aug 1, 2022
Merged

Fixed Edit on github links for v13.x documentation#3164

harshil21 merged 6 commits intopython-telegram-bot:doc-fixes-v13fromjavad94:13.x-doc-fix
Aug 1, 2022

Conversation

javad94
Copy link

Checklist for PRs

  • Added.. versionadded:: version,.. versionchanged:: version or.. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s

@javad94
Copy link
Author

btw jinja2 gives ImportError when usingsphinx-build docs/source docs/build/html command. Downgrading jinja2 from3.1.2 to3.0.3 fixed this issue. So should I updaterequirements-docs.txt too?

Traceback (most recent call last):  File "C:\Users\Javad\Anaconda3\lib\runpy.py", line 197, in _run_module_as_main    return _run_code(code, main_globals, None,  File "C:\Users\Javad\Anaconda3\lib\runpy.py", line 87, in _run_code    exec(code, run_globals)  File "D:\python-projects\ptb\venv\Scripts\sphinx-build.exe\__main__.py", line 4, in <module>  File "D:\python-projects\ptb\venv\lib\site-packages\sphinx\cmd\build.py", line 25, in <module>    from sphinx.application import Sphinx  File "D:\python-projects\ptb\venv\lib\site-packages\sphinx\application.py", line 43, in <module>    from sphinx.registry import SphinxComponentRegistry  File "D:\python-projects\ptb\venv\lib\site-packages\sphinx\registry.py", line 24, in <module>    from sphinx.builders import Builder  File "D:\python-projects\ptb\venv\lib\site-packages\sphinx\builders\__init__.py", line 26, in <module>    from sphinx.util import import_object, logging, progress_message, rst, status_iterator  File "D:\python-projects\ptb\venv\lib\site-packages\sphinx\util\rst.py", line 21, in <module>    from jinja2 import Environment, environmentfilterImportError: cannot import name 'environmentfilter' from 'jinja2' (D:\python-projects\ptb\venv\lib\site-packages\jinja2\__init__.py)

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fix. Is your sphinx version the one specified in requirements-docs.txt? The error probably happens since the versions aren't exactly matching the ones we specified.

@javad94
Copy link
Author

Thanks for the fix. Is your sphinx version the one specified in requirements-docs.txt? The error probably happens since the versions aren't exactly matching the ones we specified.

Yes, it is the same version.
image

@harshil21
Copy link
Member

okay since I see you're on a venv you probably have the right versions I'd say to go ahead and add that in (Jinja2 < 3.1). Makes sense you're getting this since I seethis in the sphinx source code.

@javad94
Copy link
Author

okay since I see you're on a venv you probably have the right versions I'd say to go ahead and add that in (Jinja2 < 3.1). Makes sense you're getting this since I seethis in the sphinx source code.

Of course, done.

@harshil21harshil21 added the ⚙️ documentationaffected functionality: documentation labelJul 23, 2022
@harshil21harshil21 added this to thev13.14 milestoneJul 23, 2022
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@harshil21harshil21 changed the base branch fromv13.x todoc-fixes-v13July 24, 2022 16:08
@javad94
Copy link
Author

@harshil21 Anything else needed to merge this PR?

@harshil21harshil21 merged commit864ee7a intopython-telegram-bot:doc-fixes-v13Aug 1, 2022
@harshil21
Copy link
Member

Thanks for the contribution!

@javad94
Copy link
Author

Thanks for the contribution!

You're very welcome.

@Bibo-JoshiBibo-Joshi mentioned this pull requestAug 1, 2022
2 tasks
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
⚙️ documentationaffected functionality: documentation
Projects
None yet
Milestone
v13.14
Development

Successfully merging this pull request may close these issues.

3 participants
@javad94@harshil21@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp