Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

API 6.1 for V13#3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 10 commits intov13.xfromv13_api_6.1
Jun 28, 2022
Merged

API 6.1 for V13#3117

Bibo-Joshi merged 10 commits intov13.xfromv13_api_6.1
Jun 28, 2022

Conversation

Poolitzer
Copy link
Member

Same PR as#3112, just with V13

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@PoolitzerPoolitzer changed the titleFix: Change constant variable namingAPI 6.1 for V13Jun 24, 2022
Poolitzerand others added4 commitsJune 26, 2022 14:57
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi
Copy link
Member

Why is pre-commit failing? I thought we had managed that in#3027?

@Poolitzer
Copy link
MemberAuthor

Is it the same error or was it a different one?

@Bibo-Joshi
Copy link
Member

On this PR it's

telegram/__main__.py:44:error:unused'type: ignore'commentFound1errorin1file (checked155sourcefiles)

on#3027 it was

telegram/__main__.py:44:error:Modulehasnoattribute"__version__"  [attr-defined]Found9errorsin2files (checked155sourcefiles)

@Poolitzer
Copy link
MemberAuthor

Yeah I don't know, it works perfectly for pycharm, and it definitely fails locally when I remove the comment.

Oh hey look at that it works on CI without it.

Bibo-Joshi reacted with hooray emoji

@Bibo-JoshiBibo-Joshi merged commitdebe86a intov13.xJun 28, 2022
@Bibo-JoshiBibo-Joshi deleted the v13_api_6.1 branchJune 28, 2022 17:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 5, 2022
@harshil21harshil21 added this to the13.13 milestoneAug 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.13
Development

Successfully merging this pull request may close these issues.

3 participants
@Poolitzer@Bibo-Joshi@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp