Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Api 6.1#3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 26 commits intomasterfromapi_6.1
Jun 27, 2022
Merged

Api 6.1#3112

Bibo-Joshi merged 26 commits intomasterfromapi_6.1
Jun 27, 2022

Conversation

Poolitzer
Copy link
Member

Checklist for PRs

  • Added.. versionadded:: version,.. versionchanged:: version or.. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • If relevant:

    • Added new constants attelegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added or updatedbot_methods.rst
    • Updated the Bot API version number in all places:README.rst andREADME_RAW.rst (including the badge), as well astelegram.constants.BOT_API_VERSION

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Neat! :) Had a first look through the changes and left some smaller comments below. Will try to have a look at the tests later

@harshil21harshil21 added this to thev20.0a2 milestoneJun 21, 2022
@harshil21harshil21 added the ⚙️ bot-apiaffected functionality: bot-api labelJun 21, 2022
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fast job!

To change:

  • parameterlogin_url ofLoginUrl should be changed to sayHTTPS.
  • Also inhttps://t.me/c/1161850314/4292, they removed limits for text length and caption. Should we do that too? Or just document saying that premium users' bots' can write longer captions?

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Only have a few comments for the test :)

Copy link
Member

@harshil21harshil21 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

found out why docs were failing: Also see#3112 (comment)

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think apart from the two comments below I don't have anything else to add :) extendingcustomwebhookbot.py to use thesecret_token can surely be done in this PR but can also be done later on - might be another good first issue …

Poolitzerand others added2 commitsJune 23, 2022 09:10
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@PoolitzerPoolitzer mentioned this pull requestJun 24, 2022
async def test_premium_animation(self, bot):
# testing animation sucks a bit since we can't create a premium sticker. What we can do is
# get a sticker set which includes a premium sticker and check that specific one.
premium_sticker_chat = await bot.get_sticker_set("Flame")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

_set instead of_chat?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's my point:premium_sticker_chat ->premium_sticker_set ;P

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ohh you meant the variable I only saw the request

@PoolitzerPoolitzer mentioned this pull requestJun 25, 2022
Poolitzerand others added2 commitsJune 25, 2022 15:52
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-JoshiBibo-Joshi merged commit08e223b intomasterJun 27, 2022
@Bibo-JoshiBibo-Joshi deleted the api_6.1 branchJune 27, 2022 16:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJul 4, 2022
@harshil21harshil21 modified the milestones:v20.0a3,v20.0a2Jul 23, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

@harshil21harshil21harshil21 approved these changes

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
v20.0a2
Development

Successfully merging this pull request may close these issues.

3 participants
@Poolitzer@Bibo-Joshi@harshil21
[8]ページ先頭
©2009-2025 Movatter.jp