Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feat: Backport API 6.0 to V13#3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 23 commits intov13.xfromv13_api6.0
May 25, 2022
Merged

Feat: Backport API 6.0 to V13#3027

Bibo-Joshi merged 23 commits intov13.xfromv13_api6.0
May 25, 2022

Conversation

Poolitzer
Copy link
Member

@PoolitzerPoolitzer commentedMay 12, 2022
edited
Loading

Thiscloses#3004.

Checklist for PRs

  • Added.. versionadded:: version,.. versionchanged:: version or.. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to theCSI standard
  • Added myself alphabetically toAUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable__all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Addedself._id_attrs and corresponding documentation
    • __init__ accepts**_kwargs
  • Added new shortcuts:

    • InChat &User for all methods that acceptchat/user_id
    • InMessage for all methods that acceptchat_id andmessage_id
    • For newMessage shortcuts: Addedquote argument if methods acceptsreply_to_message_id
    • InCallbackQuery for all methods that accept eitherchat_id andmessage_id orinline_message_id
  • If relevant:

    • Added new constants attelegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Add new message types toMessage.effective_attachment
    • Added new handlers for new update types
      • Add the handlers to the warning loop in theConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added or updatedbot_methods.rst
    • Updated the Bot API version number in all places:README.rst andREADME_RAW.rst (including the badge), as well astelegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data intg.ext.Bot for new methods that either accept areply_markup in some form or have a return type that is/containstelegram.Message

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! Found some small errors:

@harshil21harshil21 added this to the13.12 milestoneMay 12, 2022
@harshil21harshil21 added ⚙️ bot-apiaffected functionality: bot-api 🛠 backportchange type: backport labelsMay 12, 2022
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@PoolitzerPoolitzer linked an issueMay 12, 2022 that may beclosed by this pull request
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

great work 👍 some nitpicking below

about pre-commit.ci: we can either tell it to recurse submodules (we'd have to change that on master, I guess) or add something like[skip pre-commit.ci] to the commit messages on v13.x.

[skip pre-commit.ci]
# Conflicts:#README.rst#README_RAW.rst#docs/source/telegram.menubuttoncommands.rst#docs/source/telegram.menubuttondefault.rst#docs/source/telegram.menubuttonwebapp.rst
also improve some doc strings[skip pre-commit.ci]
[skip pre-commit.ci]
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

pre-commit is failing because there's a py36 related workaround still inext.__init__, please remove that. otherwise LGTM from my side.

@Bibo-Joshi
Copy link
Member

ps:[skip pre-commit.ci] apparently has no effect? what's up with deppsource?

@PoolitzerTelegram GithubBot Revised
Copy link
MemberAuthor

@Bibo-Joshi Both of them unrelated to my changes I think.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I just see that codecov marks some of eth "mutually exclusive" tests as uncovered - can you add corresponding tests?

I told deepsource to ignore the 3 issues. for pre-commit, can you try one of the otherdocumented comments and/or putting it into the first line of the commit message? If neither of that works, I'll probably change the submodules setting on master …

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for pre-commit, can you try one of the otherdocumented comments and/or putting it into the first line of the commit message? If neither of that works, I'll probably change the submodules setting on master …

@Bibo-JoshiBibo-Joshi merged commitef2a052 intov13.xMay 25, 2022
@Bibo-JoshiBibo-Joshi deleted the v13_api6.0 branchMay 25, 2022 15:40
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 1, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi left review comments

@harshil21harshil21harshil21 requested changes

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

Assignees
No one assigned
Labels
🛠 backportchange type: backport⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
13.12
Development

Successfully merging this pull request may close these issues.

Backport API 6.0 to v13
3 participants
@Poolitzer@Bibo-Joshi@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp