- Notifications
You must be signed in to change notification settings - Fork5.7k
#2764; Implemented "prefallbacks" feature#2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi. The situation hasn't changed much since you opened#2764: We're still working on asyncio and gathering todos for CH in#2770. Note that it's not clear when we'll have the capacity to tackle#2770. Please either
|
Hi. I closed my previous PR. can you please give me a review is my code and PR is okay and I can take another PR? |
Thanks
Not at this point, no. As explained above, we're currently busy with getting the asyncio release ready and overhauling CH not one of the very next todo items.
I highly recomment to first outline your idea & thoughts on implementation in either a new feature request issue or on#2770 for
TBH I don't see this getting added to the main lib. If you are interested, you cann add a contribution to ptbcontrib instead. |
david-shiko commentedApr 19, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Okay. I will very wait until you will release a new CH implementation because most likely my implementation will depend on new CH version :)
I think we should do a poll. I see this as an extremely helpful tool. The case below is pretty easy but still makes a code cleaner. It helps to convert This:
To this:
|
can we close due to inactivity / adding it to the TODO for ConvHandler at a later stage? |
Imagine you have such CH:
Here you should apply & ~Filter for every handler in states to prevent catching a cancel command.
But it can be easily avoided by adding a list of handlers that should trigger before any other update.