Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replacing git.io links#2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 15 commits intopython-telegram-bot:v14frommurugu-21:v14
Jan 21, 2022
Merged

Replacing git.io links#2872

Bibo-Joshi merged 15 commits intopython-telegram-bot:v14frommurugu-21:v14
Jan 21, 2022

Conversation

murugu-21
Copy link
Contributor

Changed all references to git.io in reference to issue [#2861].

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Copy link
Member

@harshil21harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice work!

@harshil21harshil21 changed the titleV14Replacing git.io linksJan 21, 2022
@harshil21harshil21 added this to thev14 milestoneJan 21, 2022
Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! added two more comments.
If you haven't already, please build the docs locally and check that the changes render correctly. see thecontrib guide for details on how to build the docs locally.

murugu-21and others added8 commitsJanuary 21, 2022 15:30
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@murugu-21
Copy link
ContributorAuthor

Thanks for the PR! added two more comments. If you haven't already, please build the docs locally and check that the changes render correctly. see thecontrib guide for details on how to build the docs locally.

I have built and opened the documentation, but how can i check which parts changed?

@Bibo-Joshi
Copy link
Member

I have built and opened the documentation, but how can i check which parts changed?

From the edits that you made, the following are part of the documentation (I'm linking the corresponding pages on python-telegram-bot.readthdocs.org - please look at the corresponding local files instead):

In the html files, please look for the places that you have made changes to and check that they look okay and that the links are clickable + lead to the correct location.

@murugu-21
Copy link
ContributorAuthor

murugu-21 commentedJan 21, 2022
edited
Loading

I have built and opened the documentation, but how can i check which parts changed?

From the edits that you made, the following are part of the documentation (I'm linking the corresponding pages on python-telegram-bot.readthdocs.org - please look at the corresponding local files instead):

In the html files, please look for the places that you have made changes to and check that they look okay and that the links are clickable + lead to the correct location.

  • Changes.rst
    image
    image

  • _dice.py
    image

  • _builders.py
    image
    image

  • _conversationhandler.py
    image

  • _extbot.py
    image

All links verified and screenshots attached from my local build for docs.

Bibo-Joshi reacted with heart emoji

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 👍

@Bibo-JoshiBibo-Joshi merged commit2d70838 intopython-telegram-bot:v14Jan 21, 2022
@Bibo-Joshi
Copy link
Member

Thank you for the contribution!

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJan 28, 2022
@murugu-21murugu-21 deleted the v14 branchMarch 10, 2022 17:19
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@Bibo-JoshiBibo-JoshiBibo-Joshi approved these changes

@harshil21harshil21harshil21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v20.0a0
Development

Successfully merging this pull request may close these issues.

3 participants
@murugu-21@Bibo-Joshi@harshil21

[8]ページ先頭

©2009-2025 Movatter.jp