Hi. Thanks for the PR. TBH, I haven't looked in too much detail, yet.

Regarding tests: I'm a bit surprised that we don't test clean at all. But If I see correctly, it should be enough to mockBot.get_updates to return a custom list of updates. You can addmonkeypatch to the args of the test function and usemonkeypatch.setattr(bot, 'get_updates', 'some_func_to_call_instead_of_get_updates') for that. We usemonkeypatch a lot in the tests, so you should be able to find examples :)

A few other things I noticed:

• It would be desirable to also allowdatetime input forclean (naive datetimes should be interpreted as UTC)
• AfterAdd tz kwarg to from_timestamp() #1621message.date is already timezone aware, so you shouldn't have to replace the timezone
• In fact, we'll need to make sure that different timezones are handled correctly, especially fordatetime. We have a custom fixturetimezone for that, that you can use as arg for the test functions

If you have more questions, please don't hesitate and ask :)

Ok, I'll look into it. Is the use of**kwargs like this accepted?

Ok, I'll look into it. Is the use of**kwargs like this accepted?

Mh … I guess it would be cleaner to either add an explicit argumentaction_db_kwargs or usefunctools.partial to pass thetimedelta/datetime tobootstrap_clean_time…

A few other things I noticed:

* It would be desirable to also allow `datetime` input for `clean` (naive datetimes should be interpreted as UTC)* After #1621 `message.date` is already timezone aware, so you shouldn't have to replace the timezone* In fact, we'll need to make sure that different timezones are handled correctly, especially for `datetime`. We have a custom fixture `timezone` for that, that you can use as arg for the test functions

Done. Freaking hate handling datetimes....

Ok, I'll look into it. Is the use of**kwargs like this accepted?

Mh … I guess it would be cleaner to either add an explicit argumentaction_db_kwargs or usefunctools.partial to pass thetimedelta/datetime tobootstrap_clean_time…

Done, used functools.partial. Thx btw, learned something new today :)

note to self
TODO:

• if code accepted copy code to start_webhook
• Testing.py
• cleanup

I keep running into issues w/ pytest to get it running properly (keep kettingImportWarning. Do y'all have a working docker-ptb-dev available, amd64-*nix?

No but we have dev requirements did you install them?

Basically, I fear that we might construct a very specific solution for a complex use case, which might lead to it either being not very useful and/or people wanting to add more and more options to it in order to adapt to their wishes.
But maybe you see things differently and/or have a clever solution for the things a mentioned. Anyway, I'd like to hear what you think :)

I haven't been able to come up with a all encompassing solution ... i guess you are right, it's too specific and not worth the effort.

I'll close this PR.

Okay. Still, thanks for taking the time and making the effort. It's always appreciated :)