Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Api 4.8#1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 7 commits intomasterfromapi-4.8
May 2, 2020
Merged

Api 4.8#1917

Bibo-Joshi merged 7 commits intomasterfromapi-4.8
May 2, 2020

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-JoshiBibo-Joshi commentedApr 24, 2020•
edited
Loading

Pure API changes

  • Bot.send_poll:explanation,explanation_parse_mode,
  • Poll.{explanation, explanation_entities, open_period, close_date}
  • Bot.send_dice:emoji (for whatever reason, sending a 'darts' is considered a die now …
  • Dice.emoji

Convenience stuff

  • Poll.parse_explanation_entity/ies
  • Filters.dice.dice andFilters.dice.darts for filtering only the corresponding emojis. Allow theFilters.dice.*([1, 2]) syntax for both

Todo

  • Release notification should maybe include a statemant, thatDice a second positional argument.
  • Telegram seems to have changed something with the photos. Gettingtelegram.error.BadRequest: Type of file mismatch. Need to investigate

@Bibo-JoshiBibo-Joshi added the ⚙️ bot-apiaffected functionality: bot-api labelApr 24, 2020
@PoolitzerTelegram GithubBot Revised
Copy link
Member

@Bibo-Joshi Last time I faced this error in the support groups I suggested checking the dimensions of it. Maybe try uploading said photo as document, if that works, that might be it?

@Bibo-JoshiTelegram GithubBot Revised
Copy link
MemberAuthor

@Poolitzer Problem seems to be sending a photo via

with open('tests/data/thumb.jpg', 'rb') as f:    bot.send_photo(chat_id, f)

Problem persists, if I swattests/data/telegram.jpg withtelegram.png orthumb.jpg. However, I have no problems sending the to myself with a personal bot(token). Could that be a type of flood control? We have been getting some flooding errors in the tests recently …@tsnoam maybe we can add new/replace the existing tests bots?

Copy link
Member

@PoolitzerPoolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

great PR, slight improvement

@Poolitzer
Copy link
Member

One thing: What about adding the emojis from Dice as constants? We normally do that. Right now we only have a list.

@Bibo-Joshi
Copy link
MemberAuthor

One thing: What about adding the emojis from Dice as constants? We normally do that. Right now we only have a list.

Added that. Still kept theALL_EMOJI list, though

@PoolitzerTelegram GithubBot Revised
Copy link
Member

@Bibo-Joshi Sure, didnt complain about that ;P

@Bibo-Joshi
Copy link
MemberAuthor

CI Fail:test_max_caption_length gives an Internal server error for some reason. seems unrelated.
Coverage: can't test utf-16 encoding, that's basically it. Still, codecov is satisfied.

Copy link
Member

@tsnoamtsnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In general looks good. A small comment on docstring.

However, I did not understand the following action item in the PR description:

Release notification should maybe include a statemant, that Dice a second positional argument.

Co-authored-by: Noam Meltzer <tsnoam@gmail.com>
@Bibo-JoshiBibo-Joshi merged commitc7c56ad intomasterMay 2, 2020
@Bibo-JoshiBibo-Joshi deleted the api-4.8 branchMay 2, 2020 09:56
@Bibo-JoshiBibo-Joshi mentioned this pull requestMay 12, 2020
6 tasks
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsAug 17, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@tsnoamtsnoamtsnoam left review comments

@PoolitzerPoolitzerPoolitzer requested changes

Assignees
No one assigned
Labels
⚙️ bot-apiaffected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Bibo-Joshi@Poolitzer@tsnoam
[8]ページ先頭
©2009-2025 Movatter.jp