python-telegram-bot/python-telegram-botPublic

NotificationsYou must be signed in to change notification settings
Fork5.7k
Star27.6k

4.6 API update#1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Bibo-Joshi merged 32 commits intomasterfrom4.6-update

Mar 29, 2020

Merged

4.6 API update#1723

Bibo-Joshi merged 32 commits intomasterfrom4.6-update

Mar 29, 2020

Conversation

Copy link

Member

Poolitzer commentedJan 23, 2020•
edited by Bibo-Joshi
Loading

docs need to be built and checked. Tests should run through now.

WhenAPI 4.5 #1508 is merged to master, merge master and updateMessage._parse_* to handle theMessageEntities.language attribute correctly. Doesn't actually do anything yet, but we should still add it toMessage.text_html and friends
Maketest_official fail again (i.e. partly revertimprove CI #1716)

closes#1722

First take on 4.6 support

9c8b803

Bibo-Joshi added the ⚙️ bot-apiaffected functionality: bot-api label

Jan 23, 2020

Copy link

MemberAuthor

Poolitzer commentedJan 23, 2020

I am pretty sure I would need to add the new objects to the init file, didn't do it.

Poolitzer added this to the12.4.2 milestone

Jan 23, 2020

Copy link

MemberAuthor

Poolitzer commentedJan 23, 2020

Okay, all failed tests are unrelated, I think

Poolitzer changed the title~~First take on 4.6 support~~4.6 ali update

Jan 23, 2020

Poolitzer changed the title~~4.6 ali update~~4.6 API update

Jan 23, 2020

Bibo-Joshi reviewed

Jan 23, 2020

View reviewed changes

telegram/messageentity.py OutdatedShow resolvedHide resolved

improved docs

9e7274a

Copy link

MemberAuthor

Poolitzer commentedJan 24, 2020

telegram/keyboardbutton.py:docstring of telegram.KeyboardButton:41: WARNING: Unexpected indentation.

I can't get rid of that, but I don't think I have inserted that error :D

Bibo-Joshi mentioned this pull request

Jan 24, 2020

Make (most) objects comparable#1724

Merged

4 tasks

Minor doc formattings

8d0fa03

Copy link

Member

Bibo-Joshi commentedJan 24, 2020

telegram/keyboardbutton.py:docstring of telegram.KeyboardButton:41: WARNING: Unexpected indentation.
I can't get rid of that, but I don't think I have inserted that error :D

Yes you did ;P Don't put whitespaces on begging of lines - linebreaks count as whitespace.

Bibo-Joshi requested changes

Jan 24, 2020

View reviewed changes

Copy link

Member

Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR!
Apart from my nitpicking below we should add a test files for the newKeyboardButtonPollType andPollAnswer or integrate it intotest_keyboardbutton.py andtest_poll.py, respectively.

telegram/__init__.py OutdatedShow resolvedHide resolved

telegram/bot.py OutdatedShow resolvedHide resolved

telegram/keyboardbuttonpolltype.py OutdatedShow resolvedHide resolved

telegram/poll.py OutdatedShow resolvedHide resolved

telegram/poll.pyShow resolvedHide resolved

telegram/poll.py OutdatedShow resolvedHide resolved

added poll and poll_answer to filters

d265ecc

Copy link

MemberAuthor

Poolitzer commentedJan 25, 2020

I added the missing filter as discussed in private. Do I have to add tests?

added tests, fixed mentioned issues

0849835

Bibo-Joshi mentioned this pull request

Jan 26, 2020

Add poll messages support to filters#1673

Merged

added poll_answer + poll filter tests

7d25d19

Copy link

Member

Bibo-Joshi commentedJan 27, 2020

Telegram added anote toKeyboardButton about which versions supportrequest_poll. Please add this one here as well. I'll try to review again shortly :)

Copy link

MemberAuthor

Poolitzer commentedJan 28, 2020

@Bibo-Joshi but I already did?

python-telegram-bot/telegram/keyboardbutton.py

Lines 53 to 54 in7d25d19

	:attr:`request_poll` option will only work in Telegram versions released after 23 January,
	2020. Older clients will receive unsupported message.

Bibo-Joshi reviewed

Jan 28, 2020

View reviewed changes

tests/test_filters.py OutdatedShow resolvedHide resolved

python-telegram-bot deleted a comment fromPoolitzer

Jan 29, 2020

Bibo-Joshiand others added3 commits

January 31, 2020 17:09

Update docs according to official API docs

a929274

introducing pollhandler and pollanswerhandler

6239d9a

Merge remote-tracking branch 'upstream/4.6-update' into 4.6-update

5557e2a

github-actionsbot reviewed

Feb 2, 2020

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

Copy link

MemberAuthor

Poolitzer commentedFeb 2, 2020

Missing: Tests and docs for new handlers.

Maybe improving pollbot docs.

Poolitzer added2 commits

February 2, 2020 21:39

First take on 4.6 support

bd1eafe

improved docs

4836de4

sharunkumar suggested changes

Feb 8, 2020

View reviewed changes

telegram/bot.py OutdatedShow resolvedHide resolved

sharunkumarand others added3 commits

February 8, 2020 22:56

correct_option_id validated with None

8f1f251

when trying to send a poll with correct option id 0 it was failing. Now None check is done so that even when 0 is passed it is assigned.

Merge pull request#1764from sharunkumar/patch-1

a5e770f

correct_option_id validated with None

improving example

a36ffd2

Copy link

MemberAuthor

Poolitzer commentedFeb 10, 2020•
edited
Loading

Id live to have you "helping" ;P

Also, reminder to myself, I need to include the poll filter in the example

Copy link

Member

Bibo-Joshi commentedFeb 10, 2020

Id live to have you "helping" ;P

Will try to. Probably will take a few days

Poolitzerand others added7 commits

February 10, 2020 20:56

improving code

517cc3d

adding poll filter example to the pollbot.py

92556df

Update Readme

f9883e3

simplify pollbot.py and add some comments

a275257

add tests for Poll(Answer)Handler

a2fa913

Merge branch 'master' into 4.6-update

4556f09

We just want Filters.poll, not Filters.update.poll

ded8788

Copy link

Member

Bibo-Joshi commentedFeb 15, 2020

Here you go :-*
Took the liberty to simplify the example a bit and restore the intended behaviour of Filters.poll

Copy link

MemberAuthor

Poolitzer commentedFeb 15, 2020

Thank you very much :)

Bibo-Joshi mentioned this pull request

Mar 6, 2020

[FEATURE] Duplicate#1813

Closed

Copy link

simonsmh commentedMar 11, 2020

When will this pull request get merged?

Copy link

MemberAuthor

Poolitzer commentedMar 11, 2020

We dont like giving an ETA, sorry. That being said its on our list (obviously). Maintainers just need to find time in their life.

Copy link

simonsmh commentedMar 11, 2020

Actually I am using this branch for quite a long time and doesn't meet any problem so far. I'm just curious for why it doesn't get any update for nearly a month as I need some of the new feature to show my idea to others. Anyway thanks for your work.