Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added file_unique_id attrs from API 4.5 and updated tests for it#1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Bibo-Joshi merged 3 commits intopython-telegram-bot:nested-entitiesfromdmytrohoi:nested-entities
Jan 8, 2020
Merged

Conversation

dmytrohoi
Copy link
Contributor

Last changes for#1689 issue.

WARNING: This is just a commit to send the code! Changes are not checked and not launched.

Could you please review, spell check and run tests regarding committed changes?

@dmytrohoi
Copy link
ContributorAuthor

@Bibo-Joshi could you help me with these changes?

@Bibo-Joshi
Copy link
Member

Thanks for the PR! I'll check everything, might take a few days.

@dmytrohoi
Copy link
ContributorAuthor

Sorry for the delay, but I checked all the tests and used flake8 in the last commit.

Could you check the tests and changes in both commits together.

Copy link
Member

@Bibo-JoshiBibo-Joshi left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pre-Commit hooks and tests pass (on my machine)

If I understand correctly, we should use the newfile_unique_id in theget_file methods now. Can you change that and make sure the corresponding tests pass?
(I did not understand correctly)

@dmytrohoi

This comment has been minimized.

@dmytrohoi
Copy link
ContributorAuthor

@Bibo-Joshi required changes has been done.

I'm waiting for next steps. :)

@Bibo-Joshi
Copy link
Member

LGTM 👍
I'll merge and request a another review for the complete API 4.5 PR. If there are minor changes to be done, I'll cover them, but may reach out, if bigger changes are requested.
Thanks for the help in any case!

dmytrohoi reacted with hooray emoji

@Bibo-JoshiBibo-Joshi merged commite568b30 intopython-telegram-bot:nested-entitiesJan 8, 2020
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@Bibo-JoshiBibo-JoshiBibo-Joshi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dmytrohoi@Bibo-Joshi
[8]ページ先頭
©2009-2025 Movatter.jp