- Notifications
You must be signed in to change notification settings - Fork5.7k
Add poll messages support to filters#1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Bibo-Joshi approved these changesDec 29, 2019
We added both poll and poll_answer filters in the the API 4.6 PR#1723, so I'm going to close this one. Still, thanks for taking the time and doing this PR :) |
Member
Poolitzer commentedJan 26, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Actually, we don't, we add the update type, not the message attribute; we can just merge this on its own. |
tsnoam approved these changesJan 26, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PRfixes#1672
It adds poll message support to filters (
telegram.ext.filters.Filters.poll). Both filter code and tests are updated accordingly.