Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove checks for None on assignement for opt args#1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tsnoam merged 2 commits intomasterfromsimple-optional-assignements
Nov 23, 2019

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-JoshiBibo-Joshi commentedNov 7, 2019•
edited
Loading

As pointed out by@jh0ker in the dev-chat, the checks

if arg:    self.arg = arg

are not necessary, sinceTelegramObject.to_dict() ignoresNone anyway.

AlsoCloses#1594

@tsnoam
Copy link
Member

workflow fails on py3.5 & py3.7 on windows. need to investigate.

@tsnoam
Copy link
Member

this PR can be moved to milestone 12.4 if fixing the CI will take too long.

@Bibo-Joshi
Copy link
MemberAuthor

Will try to investigate tomorrow

@Bibo-Joshi
Copy link
MemberAuthor

Tests succeed after restart. All I saw was something about set_webhook_info which should be unrelated ...

@tsnoamtsnoam merged commita5ba64b intomasterNov 23, 2019
@tsnoamtsnoam deleted the simple-optional-assignements branchNovember 23, 2019 16:05
This was referencedJan 19, 2020
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@tsnoamtsnoamtsnoam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.3
Development

Successfully merging this pull request may close these issues.

[BUG] InlineKeyboardButton with switch_inline_query='' doesn't work
3 participants
@Bibo-Joshi@tsnoam@Poolitzer
[8]ページ先頭
©2009-2025 Movatter.jp