- Notifications
You must be signed in to change notification settings - Fork5.7k
filter accepts a Message by default, not an Update#1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The method BaseFilter.filter() accepts a Message by default. Only ifclass attribute 'update_filter' is set to True the method accepts anUpdate.
Poolitzer requested changesNov 4, 2019
Uh oh!
There was an error while loading.Please reload this page.
Bibo-Joshi approved these changesNov 7, 2019
Poolitzer approved these changesNov 13, 2019
Good!--Emanuele Petriglia (ema-pe)Sent from my mobile. Please excuse my brevity. …On 18 November 2019 19:36:50 CET, Bibo-Joshi ***@***.***> wrote:@ema-pe I merged master so tests will succeed and changed the last lineof the PR description so it will automatically close#1595 on merge :)--You are receiving this because you were mentioned.Reply to this email directly or view it on GitHub:#1596 (comment) |
After some discussion, we're actually a bit unsure about this change. Hence, I move this PR to Milestone 13. We'll need some more internal discussion before making a decision. |
We decided to go another way in#2032, so I'll be closing this. Still, thank you for PRing :) |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The method
BaseFilter.filter()accepts aMessageby default. Only ifclass attribute
update_filteris set toTruethe method accepts anUpdate.This pull request provides a commit that emphasizes this behaviour, because one can misunderstand it.
Closes:#1595