- Notifications
You must be signed in to change notification settings - Fork5.7k
Make MessageEntity objects comparable#1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Merged
Uh oh!
There was an error while loading.Please reload this page.
Eldinnie requested changesAug 23, 2019
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit383044a.
Bibo-Joshi added a commit that referenced this pull requestMar 28, 2020
Bibo-Joshi added a commit that referenced this pull requestMar 28, 2020
* Allow for nested MessageEntities in Message._parse_markdown/html, adjust tests* remove testing relict* Use MessageEntitys new equality check (#1465)* Remove unused variable* Update to custom_title feature and slow_mode_delay optionChanges: - custom_title for ChatMember - new method setChatAdministratorCustomTitle for Bot - new slow_mode_delay for ChatUpdate due to new API future `custom_title` from API 4.5 (https://core.telegram.org/bots/api#december-31-2019)* Minor typo fix* Comply with Flake8* Add new MessageEntities and MarkdownV2* Added file_unique_id attrs from API 4.5 and updated tests for it* Fixed test and checked using flake8* Fixed ChatPhoto documentation* Fix Flake8* Add setChatAdminCstmTitle to Bot* Rename MDV2 methods* Change files id attrs to unique id* correct id_attrs for chat_photo* Revert "temporarily skip tests failing b/c missing api 4.5 (#1738)"This reverts commit7cde6ca.* Fix text_markdown_v2 for monospace and text_links* closing remarks from pieter* Minor fix in escape_markdown, improve tests for it* Fix offset bug in Message._parse_** Add test_chatphoto.py* remove debug print from test_message.py* try making codecov happy* Update readme* all hail codecov* Improve Link handling for MarkdownV1 and adjust tests.Closes#1654* Dont use beginning of pre-entity as language in _parse_markdown* Remove debug print* Dummy commit to try fix codecovCo-authored-by: Hoi Dmytro <dmytro.hoi@gmail.com>Co-authored-by: Dmytro Hoi <code@dmytrohoi.com>Co-authored-by: poolitzer <25934244+poolitzer@users.noreply.github.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now comparison of
MessageEntityobject fails, e.g.yields
True.To make
MessageEntityobjects comparable, I usedTelegramObjects attribute_id_attr. Also, I added atest_equalitytotest_messageentity.